Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom color border style #2843

Merged
merged 4 commits into from
Jan 17, 2024
Merged

fix: custom color border style #2843

merged 4 commits into from
Jan 17, 2024

Conversation

subordon
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进 Button 自定义按钮的颜色未同步修改边框 #2842
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8bcffec) 85.04% compared to head (f137275) 85.03%.
Report is 6 commits behind head on v4.

Files Patch % Lines
src/packages/__VUE/button/button.vue 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2843      +/-   ##
==========================================
- Coverage   85.04%   85.03%   -0.01%     
==========================================
  Files         169      169              
  Lines       21274    21274              
  Branches     2420     2421       +1     
==========================================
- Hits        18092    18091       -1     
- Misses       3165     3166       +1     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu linked an issue Jan 16, 2024 that may be closed by this pull request
@eiinu
Copy link
Member

eiinu commented Jan 16, 2024

border: 0 会使得整个按钮的宽高会发生变化,多个按钮并排时可能有一些不对齐。
可以考虑改成 border-color: transparent

按钮本身也设置了 background-origin: border-box 样式,背景颜色会从边框开始。

@subordon
Copy link
Contributor Author

高度没影响,宽度会有变化,调整了下。 @eiinu

@eiinu eiinu merged commit 2b3847d into jdf2e:v4 Jan 17, 2024
5 of 6 checks passed
@subordon subordon deleted the fix/button branch March 18, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button 自定义按钮的颜色未同步修改边框
2 participants