Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(textarea, taro): 修复 h5 下双向绑定失效的问题 (#2768)" #2935

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

eiinu
Copy link
Member

@eiinu eiinu commented Feb 29, 2024

这里存在一个难以解决的问题。参考 #2470

NutUI 发布的包代码是经过构建之后的 js 代码而非是 vue 模板源码,而 Taro 对于 H5 组件的转换在这个阶段之前。

This reverts commit 4c7d346.

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@eiinu eiinu linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.48%. Comparing base (7fb5ebe) to head (f80c1a0).

Additional details and impacted files
@@           Coverage Diff           @@
##               v4    #2935   +/-   ##
=======================================
  Coverage   85.48%   85.48%           
=======================================
  Files         177      177           
  Lines       21878    21878           
  Branches     2532     2533    +1     
=======================================
  Hits        18702    18702           
  Misses       3159     3159           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu merged commit 577a381 into jdf2e:v4 Feb 29, 2024
6 checks passed
@eiinu eiinu deleted the fix-textarea-h5 branch February 29, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nut-textarea 组件报错
1 participant