Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cascader):cascader组件支持配置lockScroll、teleport、teleportDisable #3150

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Azraelj
Copy link
Contributor

@Azraelj Azraelj commented Jul 18, 2024

这个 PR 做了什么? (简要描述所做更改)
cascader组件支持传入lockScroll、teleport、teleportDisable属性以支持使用者通过手动控制这些属性解决#3134 中提到的问题
这个 PR 是什么类型? (至少选择一个)

  • feat: 新特性提交
  • fix: bug 修复
  • docs: 文档改进
  • style: 组件样式/交互改进
  • type: 类型定义更新
  • perf: 性能、包体积优化
  • refactor: 代码重构、代码风格优化
  • test: 测试用例
  • chore(deps): 依赖升级
  • chore(demo): 演示代码改进
  • chore(locale): 国际化改进
  • chore: 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI H5 @nutui/nutui
  • NutUI Taro @nutui/nutui-taro

这个 PR 是否已自测:

Summary by CodeRabbit

  • 新功能
    • 在应用中新增了 lockScrollteleportteleportDisable 属性,增强了与滚动行为和元素传送相关的选项。

Copy link

coderabbitai bot commented Jul 18, 2024

Walkthrough

这次变化对cascader组件进行了增强,添加了lockScrollteleportteleportDisable属性。这些新属性与相应的数据属性绑定,提高了组件的功能性,特别是在滚动行为和元素传送方面。

Changes

文件路径 变更摘要
src/packages/.../cascader/index.vue 增加了lockScrollteleportteleportDisable属性,增强了组件功能

Poem

代码流转如风轻,
新增属性添光明。
锁定滚动稳如山,
传送元素如幻影。
功能提升真美好,
组件世界更精妙。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a415d0b and 5aad06d.

Files selected for processing (1)
  • src/packages/__VUE/cascader/index.vue (1 hunks)
Additional comments not posted (3)
src/packages/__VUE/cascader/index.vue (3)

8-8: 验证 lockScroll 属性的使用

请确保 lockScroll 属性在 nut-popup 组件中正确使用,并且其默认值和类型符合预期。


9-9: 验证 teleport 属性的使用

请确保 teleport 属性在 nut-popup 组件中正确使用,并且其默认值和类型符合预期。


10-10: 验证 teleportDisable 属性的使用

请确保 teleportDisable 属性在 nut-popup 组件中正确使用,并且其默认值和类型符合预期。

@eiinu eiinu linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.18%. Comparing base (a415d0b) to head (5aad06d).

Files Patch % Lines
src/packages/__VUE/cascader/index.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #3150      +/-   ##
==========================================
- Coverage   81.20%   81.18%   -0.02%     
==========================================
  Files         226      226              
  Lines       18139    18142       +3     
  Branches     2485     2485              
==========================================
  Hits        14729    14729              
- Misses       3392     3395       +3     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu merged commit 05c3bef into jdf2e:v4 Jul 18, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

popup中嵌套popup或有动态渲染的popup时 lock-scroll失效
2 participants