Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - wait for: either url #128

Open
MattBidewell opened this issue Nov 22, 2022 · 1 comment
Open

Feature request - wait for: either url #128

MattBidewell opened this issue Nov 22, 2022 · 1 comment

Comments

@MattBidewell
Copy link

A nice to have would be the ability to OR URLs.

One implementation could be:
wait-on (tcp:[::1]:80 tcp:127.0.0.1:80)

Alternatively, it could be pure config.

If I've misread the docs and this already exists, then my apologies.

Issue I'm solving:
Since updating to Node17+. Node DNS lookups return IPv6 first. Which might not seem like a massive issue, but localhost URLs are now in theory [::1]:{port} rather than 127.0.0.1:{port}

My current project is using wait on like so - wait-on localhost:5000 localhost:5001 and will hang as the servers are starting on [::1]:5000 ... etc..

@metcoder95
Copy link

Adding my two cents, I think would be better to make wait-on do listen on both IPv by default when it encounters a localhost origin within the resources passed through, at least until nodejs/node#44731 gets merged.

But the OR feature will be indeed a good addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants