Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support urllib3>=2 #73

Open
rzuckerm opened this issue Oct 9, 2024 · 0 comments
Open

Please support urllib3>=2 #73

rzuckerm opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rzuckerm
Copy link

rzuckerm commented Oct 9, 2024

Details

Our build system installs a python package that contains khoros==5.4.0, and it is installed through pip. I'm seeing this error:

khoros 5.4.0 has requirement urllib3<1.27.0,>=1.26.2, but you'll have urllib3 2.2.3 which is incompatible.

For some reason pip does not exit with a non-zero status, so everything seems to work. However, this is concerning since pip may actual start treating this as a severe enough error to not allow khoros to be installed.

Steps to Reproduce

I think you should be able to reproduce this by creating a requirements.txt file that contains the following:

khoros==5.4.0
urllib3==2.2.3

In a virtualenv, run pip install -r requirements.txt

Expected Behavior

The pip error should be not shown.

Suggestions or Proposals

I'm not sure how this package uses urllib3, but it should support the 2.x versions since they have a lot of security fixes.

@rzuckerm rzuckerm added the bug Something isn't working label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants