Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout incorrectly applied to generated redirect pages #112

Closed
alexbaldwin opened this issue Jun 24, 2016 · 13 comments
Closed

Layout incorrectly applied to generated redirect pages #112

alexbaldwin opened this issue Jun 24, 2016 · 13 comments
Labels
frozen-due-to-age

Comments

@alexbaldwin
Copy link

When running html-proofer on the redirect pages, I'm getting Misplaced DOCTYPE declaration warnings.

The offending line is producing <!DOCTYPE html>, but I'd prefer to set layout: false on these if it's generating it's own page without the need for a layout or be able to specify my own layout.
@pathawks
Copy link
Member

Can you provide a bit more information? What exactly are you running html-proofer on? Can you upload an example offending page as a Gist?

Layouts should not be applied to redirect pages; this should already be the case

@alexbaldwin
Copy link
Author

@pathawks here's an example and the Gemfile.lock for this build. Thank you Pat!

@pathawks
Copy link
Member

Is your site source public?
In your config, are you specifying a default layout for pages? It looks like the default layout is being applied to the redirect page somehow.

@pathawks pathawks changed the title Misplaced DOCTYPE declaration error Layout incorrectly applied to generated redirect pages Jun 29, 2016
@jdalton
Copy link

jdalton commented Jul 5, 2016 •
edited
Loading

I'm seeing this issue too. I have a default layout specified and the redirect html, doctype and all, is nested inside its {{ content }}.

Related to #94.

@pathawks
Copy link
Member

pathawks commented Jul 5, 2016

Not related to 94.

Can you provide the source of a site that exhibits this behavior?

@jdalton
Copy link

jdalton commented Jul 5, 2016

If I modify a page here to use this plugin I see the same issue that @alexbaldwin outlined.

@parkr
Copy link
Member

parkr commented Jul 6, 2016

@jdalton I believe #106 fixed this issue. It has not been released yet. @pathawks, would you mind releasing a new version?

@jdalton
Copy link

jdalton commented Jul 6, 2016

:shipit: :)

@pathawks
Copy link
Member

pathawks commented Jul 6, 2016

@parkr Do I have the privleges to cut a gem?

@parkr
Copy link
Member

parkr commented Jul 6, 2016

@pathawks You should! If you don't, let's get you access.

@pathawks
Copy link
Member

pathawks commented Jul 6, 2016

I do not.

$ script/release
jekyll-redirect-from 0.11.0 built to pkg/jekyll-redirect-from-0.11.0.gem.
Tagged v0.11.0.
Pushed git commits and tags.
rake aborted!
Pushing gem to https://rubygems.org...
You do not have permission to push to this gem.

@pathawks
Copy link
Member

pathawks commented Jul 6, 2016

Good news! A new version has just been published to RubyGems.org! That should fix the issue. If not, please reopen this issue.

@pathawks pathawks closed this as completed Jul 6, 2016
@alexbaldwin
Copy link
Author

@pathawks @parkr thanks for your help! Upgraded to the new version and it works like a charm.

@jekyll jekyll locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jdalton @parkr @pathawks @alexbaldwin @jekyllbot