Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending to grid from observable/stream #13

Open
farantesrodrigues opened this issue Sep 15, 2016 · 18 comments
Open

Appending to grid from observable/stream #13

farantesrodrigues opened this issue Sep 15, 2016 · 18 comments

Comments

@farantesrodrigues
Copy link

I'm updating the DOM by streaming an Observable into an array that feeds ngFor directive. I'm having trouble implementing masonry on this, at least with your angular2 module because each time the array changes, masonry.layout is called. Elements are attached but the transition comes from the same place (the start : top left corner). What I want is to append to masonry grid as soon as the element arrives to the stream. Can I achieve this behavior or appending to the grid from a stream is a feature I have to work on ?

@jelgblad
Copy link
Owner

Thanks for your input. I will run some test and look into this!

@jelgblad
Copy link
Owner

Hmm. So your problem is that you want to add an item so that it just pops up without it transitioning into place?

@farantesrodrigues
Copy link
Author

yes, but load it asynchronously...

@rowies
Copy link

rowies commented Oct 6, 2016

Got the same problem :) would be nice if this works in a future version :D The LayoutComplete fires every time I add an item to the array

@jelgblad
Copy link
Owner

jelgblad commented Oct 6, 2016

Yea I see the problem. But it will take some rethinking... Code ideas or PRs on how to fix stuff like this are always welcome!

@maronaquillo
Copy link

Setting the transitionDuration to 0 and add css animation on the items solves the append issue but it creates an error Cannot read property 'removeChild' of null when removing some items.

options: MasonryOptions = { transitionDuration: '0', };

@jelgblad
Copy link
Owner

@maronaquillo what version are you running?

@maronaquillo
Copy link

@AbhayVel
Copy link

I am having same issue, Still not able to resolve , not able to get it meaning of "add css animation on ". can any one provide detail?

@AbhayVel
Copy link

@maronaquillo and @jelgblad

Can you please provide solution for mentioned problem? I am not able to get it?
"Cannot read property 'removeChild' of null when removing some items."

Setting the transitionDuration to 0 and add css animation on the items solves the append issue but it creates an error Cannot read property 'removeChild' of null when removing some items.

options: MasonryOptions = { transitionDuration: '0', };

@jelgblad
Copy link
Owner

@maronaquillo @AbhayVel is this with useImagesLoaded on or off? Do you still have this issue with [email protected]?

@AbhayVel
Copy link

AbhayVel commented Oct 31, 2016

@jelgblad no, I am getting this issue as I have observable list.
Yes, I am using 0.3.0 version only.

@AbhayVel
Copy link

AbhayVel commented Nov 4, 2016

@jelgblad , Hi Can you please provide me help on this, Still I am facing following issue.
"Cannot read property 'removeChild' of null when removing some items."

@jelgblad
Copy link
Owner

jelgblad commented Nov 7, 2016

@AbhayVel if you could set up a punk showing your problem, that would be really helpful. You can fork this one: https://plnkr.co/edit/mmi5tk6hvzEazYQUGZUC?p=preview

@maronaquillo
Copy link

@jelgblad useImagesLoaded is off.
@AbhayVel It's weird but I managed to get rid of the error by setting
transitionDuration: '0.0000001s'

@nick-jonas
Copy link

@maronaquillo I have the same issue. Setting transitionDuration: '0.0000001s' does get rid of the error, however I get this long flash on the screen (everything gets wiped off and on) whenever my Observable stream is updated...

@Rich-Squirrel365
Copy link

@nick-jonas I am getting the same issue too with "Cannot read property 'removeChild' of null when removing some items." I have set transitionDuration to 0.000001s and the issue is gone but like you I get the screen rendering flash. Did you manage to either get transition 0 working or find a way to get rid of the screen flash?

I am on angular2-masonry 0.4.0

@maronaquillo
Copy link

@kedger Did you set it like this? This works on my end.
options: MasonryOptions = { transitionDuration: '0', gutter: 9, };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants