Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element type incorrect in modifier signature #225

Open
bwbuchanan opened this issue Jan 30, 2024 · 2 comments
Open

Element type incorrect in modifier signature #225

bwbuchanan opened this issue Jan 30, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bwbuchanan
Copy link

Element: HTMLElement;

This should be:

Element: ElementCSSInlineStyle;

Otherwise, the Typescript compiler complains when you try to use the modifier on SVG elements.

@jelhan jelhan added the bug Something isn't working label Jan 30, 2024
@jelhan
Copy link
Owner

jelhan commented Jan 30, 2024

Thanks for reporting. Do you have time providing a PR, which 1) fixes the issue and 2) adds test coverage for SVG usage?

@jelhan
Copy link
Owner

jelhan commented Mar 10, 2024

It has been fixed for SVG elements in #235. While working on the fix, we noticed that it is broken for <math> element as well. A fix for that one is pending. See #237 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants