Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework this a bit #68

Open
Sythelux opened this issue Feb 13, 2024 · 0 comments
Open

Rework this a bit #68

Sythelux opened this issue Feb 13, 2024 · 0 comments

Comments

@Sythelux
Copy link

Coincidentially I made Plugins/Mods for 2 C# Projects recently.

This and Vintage Story and I think this Repo could use some inspiration from how Vintage Story does the Project templating.
firstly it has a fully working nuget project template: https://github.com/anegostudios/VSdotnetModTemplates

and secondly it solved the Deployment Problem with having a CakeBuild subproject within the template. I link it here in my ready made mod:
https://gitlab.com/Sythelux/apanserbjornstory/-/tree/main/CakeBuild

I would recommend to actually make a vintage story mod as weird as this sounds to get some input on what to improve here.

Big Apologies if this isn't how you are supposed to work with issues and also sorry for being very vague. It is just, that the overall onboarding process to make a jellyfin plugin is weird.

Maybe I have a couple of specific things:

  1. When checking out I had to use the template button on the top right and not as suggested clone this project and modify it.
  2. when using the template it will keep the folder structure "Jellyfin.Plugin.Template" and I had to rename it manually and search and replace template
  3. since dotnet core there are launchSettings.json files possible. I'm using Rider (and you should consider supporting it too since you are partnering with jetbrains from what I can see in the jellyfin main repo) and the vscode launch.json is not usable in Rider.
  4. I'm currently reworking the build and deploy mechanism from that launch.json to the above shown CakeBuild and integrate it with csproj and sln files to make it easier to work with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant