Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tizen App/Web Failed to construct headers #260

Closed
hossihub opened this issue May 17, 2024 · 9 comments
Closed

Tizen App/Web Failed to construct headers #260

hossihub opened this issue May 17, 2024 · 9 comments

Comments

@hossihub
Copy link

Issue with 10.9 on TV. Failed to construct headers.

Possible solution to implement ?

remix-run/react-router#11148

@dmitrylyzo
Copy link
Collaborator

What TV model?
At least the app with 10.9.2 web works in Tizen 5 emulator.

@tourist1584970446
Copy link

I have the same issue on Tizen 3, 10.8 works fine

@tacheometry
Copy link

tacheometry commented May 18, 2024

The way to implement my patch is by building my fork of react-router in a separate folder, then setting the dependency on jellyfin-web so that it points to the locally built dependency (like npm install ../patchedReactRouter).

Afterwards, Tizen can be built and installed using the JELLYFIN_WEB_DIR env variable.

I'll update this post with more precise instructions if I'm able to find the way my friend did it.

Of course, if it is possible to update the browser, then none of this is necessary.

@thornbill
Copy link
Member

thornbill commented May 18, 2024

I suspect we could probably monkey patch the constructor to fix this while waiting on an upstream fix... something like this maybe?

var _Headers = window.Headers;
function PatchedHeaders() {
    var args = arguments || [{}];
    return _Headers.apply(null, args);
}
window.Headers = PatchedHeaders;

@dmitrylyzo
Copy link
Collaborator

dmitrylyzo commented May 18, 2024

I suspect we could probably monkey patch the constructor to fix this while waiting on an upstream fix... something like this maybe?

I thought about the same (+maybe try/catch). The question is, does this problem also exist in webOS? If so, we need to do it in web.

UPD:
webOS 4 has the same bug (TypeError: Failed to construct 'Headers': No matching constructor signature.), but it doesn't seem to use Headers.

@thornbill
Copy link
Member

Does the same patch work for both? If so let's just get it in web.

@dmitrylyzo
Copy link
Collaborator

Fixed by jellyfin/jellyfin-web#5558

@ianpaschal
Copy link

This is still occuring for me having just built and deployed the release-10.9.z branch of jellyfin-web.

@Skyluker4
Copy link

I can also confirm this happening on v10.9.9 jellyfin-web tag. It does not happen on v10.9.8 for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants