You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally sourced from a review comment in #2001 in regards to some PRs opened by @endrl, @gibahjoe and @noaione
We want to keep everything in @jellyfin-vue/frontend isolated from plugins (like the Skip intro feature @gibahjoe worked on #1887). Ideally we're looking forward to a multi-project (no build flags like in your PR either) with npm workspaces or microfrontend setup. I'm not knowledgeable enough in how to properly architecture all of that and specially microfronteds, so I'm first trying to educate myself. Once I feel confident enough, I might open a discussion to gather some feedback or a PR. But still it's much appreciated (and will allow to be shipped faster) if we get outside contributors' help in the form of RFCs or PRs. The TLDR of the ideal thing would be:
Vite projects that expand/merges with the "core" configuration (the one we have now) for build changes targeted at specific stuff. Right now 2 comes to my mind:
The one with the small set of polyfills (as the one you wanted to add for TVs)
Microfrontend architecture for features/specific components: That way, the "skip intro" button could be hooked by mounting it inside the video player's DOM and having access to the all the modules exposed by @jellyfin-vue/frontend (the main core)
All the building process should be orchestrated by an interactive CLI configurator (but also allowing headless for CI), which will configure everything for the developer
With the given examples, these are the configurations that come to my mind (& means that their configs will be merged):
Tauri Vite project & Core Vite project+ Core Vue app
Tauri Vite project & Core Vite project+ Core Vue app + Skip intro (microfrontend)
Polyfilled Vite project & Core Vite project + Core Vue app
Polyfilled Vite project & Core Vite project + Core Vue app + Skip intro (microfrontend)
Hopefully this clear enough for a vision of what we want to achieve.
Let's keep all the discussions about this in this thread, so they can be located easily at all times. Any help is appreciated! 🙌💗
Additional context
single-spa's documentation is a really good thing to start reading about the possibilities microfrontends could give us for "jellyfin-vue plugins" while keeping the core "on-point" with the core features of server.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Originally sourced from a review comment in #2001 in regards to some PRs opened by @endrl, @gibahjoe and @noaione
We want to keep everything in
@jellyfin-vue/frontend
isolated from plugins (like the Skip intro feature @gibahjoe worked on #1887). Ideally we're looking forward to a multi-project (no build flags like in your PR either) with npm workspaces or microfrontend setup. I'm not knowledgeable enough in how to properly architecture all of that and specially microfronteds, so I'm first trying to educate myself. Once I feel confident enough, I might open a discussion to gather some feedback or a PR. But still it's much appreciated (and will allow to be shipped faster) if we get outside contributors' help in the form of RFCs or PRs. The TLDR of the ideal thing would be:Vite projects that expand/merges with the "core" configuration (the one we have now) for build changes targeted at specific stuff. Right now 2 comes to my mind:
Microfrontend architecture for features/specific components: That way, the "skip intro" button could be hooked by mounting it inside the video player's DOM and having access to the all the modules exposed by
@jellyfin-vue/frontend
(the main core)All the building process should be orchestrated by an interactive CLI configurator (but also allowing headless for CI), which will configure everything for the developer
With the given examples, these are the configurations that come to my mind (& means that their configs will be merged):
Hopefully this clear enough for a vision of what we want to achieve.
Let's keep all the discussions about this in this thread, so they can be located easily at all times. Any help is appreciated! 🙌💗
Additional context
single-spa's documentation is a really good thing to start reading about the possibilities microfrontends could give us for "jellyfin-vue plugins" while keeping the core "on-point" with the core features of server.
Beta Was this translation helpful? Give feedback.
All reactions