Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ua-parser-js to detect current platform #1508

Open
ThibaultNocchi opened this issue Sep 29, 2021 · 1 comment
Open

Use ua-parser-js to detect current platform #1508

ThibaultNocchi opened this issue Sep 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ThibaultNocchi
Copy link
Member

ThibaultNocchi commented Sep 29, 2021

We could use this plugin to detect which platform we are on and improve the profile detection for instance

https://www.npmjs.com/package/ua-parser-js

@ThibaultNocchi ThibaultNocchi added the enhancement New feature or request label Sep 29, 2021
@edrohler
Copy link

If we use this everyone should note the existence of a recently found malware in specific versions. Popular NPM Library Hijacked to Install Password Stealers and Minters.

If someone were to use the version malicious version in this GH comment it might be an issue.

I scanned the package-lock.json and currently this project is using 0.7.28 so it doesn't look like an issue and a fix has been published so if anyone runs a npm i now it shouldn't be an issue either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants