Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

jx upgrade cli downloads binary when upgrade isnt needed #778

Open
cameronbraid opened this issue Dec 23, 2020 · 0 comments
Open

jx upgrade cli downloads binary when upgrade isnt needed #778

cameronbraid opened this issue Dec 23, 2020 · 0 comments

Comments

@cameronbraid
Copy link

cameronbraid commented Dec 23, 2020

❯ jx version
version: 3.1.73
❯ jx upgrade cli
using local versionstream URL https://github.com/jenkins-x/jxr-versions from Kptfile to resolve jx-cli version
downloading version 3.1.73...
Jenkins X client has been upgraded to version 3.1.73

There are two GetVersion functions in the code

pkg/version/info.go:70

uses Map["version"] or TestVersion

pkg/cmd/version/version.go:55

uses var Version or TestVersion

Looks like the makefile provides build args for pkg/cmd/version.Version

However the upgrade command uses pkg.version.GetSemverVersion() which uses pkg.version.Map["version"]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant