Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pieces of base-64 garbled output display in partial views #30

Closed
dblock opened this issue May 30, 2014 · 7 comments
Closed

Pieces of base-64 garbled output display in partial views #30

dblock opened this issue May 30, 2014 · 7 comments
Labels
confirmed bug 🐛 Definitely an ansicolor plugin bug

Comments

@dblock
Copy link
Member

dblock commented May 30, 2014

Partial truncated text.

screenshot 2014-05-30 07 30 22

screenshot 2014-05-30 07 29 53

@dblock dblock changed the title Garbage is back in output Pieces of base-64 garbled output display in partial views May 30, 2014
@ejelly
Copy link
Collaborator

ejelly commented May 30, 2014

Ah, I have a hunch. The state probably needs to be preserved across lines, which means instantiating a new filter on every line is a bad idea (at least that's how I remember it, I'm on my phone right now).

Might be an easy fix. I'm currently in the process of moving, though, so I will try to fix this when things have calmed down.

@ejelly
Copy link
Collaborator

ejelly commented Jun 5, 2014

Hmm, okay, that turned out not to be the case. The Filter is properly instantiated once.

Looking at your output, the preceding line is <pre class="console-output">, which means the (partial) output starts there. Does the garbage go away when you click on "Full Log"?

@dblock
Copy link
Member Author

dblock commented Jun 5, 2014

Yes, garbage goes away when you are looking at the full log.

@MartinNowak
Copy link
Contributor

Yes, this is simply a side-effect of #67. The base64 encoded data can't be interpreted to sth. sensible when picked up mid-stream (due to not showing the full log).

@tszmytka
Copy link
Collaborator

tszmytka commented Aug 1, 2020

Having spent a fair amount of time with #185 I can say something about this.

This issue has nothing to do with ansicolor directly. Jenkins produces the partial views simply by taking the last x bytes from the log - currently it is 150 KB - without looking if it happens to fall in the middle of an encoded ConsoleNote or not.
Any other plugin or internal Jenkins functionality that uses ConsoleNotes will exhibit the same behavior.

@dblock I think this can be closed as any attempts at fixing this would require manually updating the log file - I actually went in that direction at the beginning of #198

@dblock
Copy link
Member Author

dblock commented Aug 2, 2020

I think this can stay open since it's still an issue. I agree there's nothing sensible AnsiColor can do right now, but maybe someone encountering this problem will have a better idea (e.g. improving how Jenkins reads log tails).

@tszmytka
Copy link
Collaborator

tszmytka commented Jan 1, 2021

@dblock I've fixed this behavior directly in Jenkins some time ago already (as the ticket above shows) and forgot to post an update. Jenkins version 2.261 (or newer) will always render partial logs starting from the beginning of a line - ConsoleNotes (parts of them) will no longer show up in the output no matter what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug 🐛 Definitely an ansicolor plugin bug
Projects
None yet
Development

No branches or pull requests

4 participants