From 6f18e1ae04734d2e0fc1554842389acbeea9df1c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Herv=C3=A9=20Le=20Meur?= <hlemeur@cloudbees.com>
Date: Wed, 7 Dec 2022 15:04:04 +0100
Subject: [PATCH 1/3] [JENKINS-70169] Add missing breadcrumb items in
 resources/hudson/PluginManager

---
 core/src/main/resources/hudson/PluginManager/advanced.jelly  | 1 +
 core/src/main/resources/hudson/PluginManager/available.jelly | 1 +
 core/src/main/resources/hudson/PluginManager/installed.jelly | 1 +
 core/src/main/resources/hudson/PluginManager/table.jelly     | 1 +
 4 files changed, 4 insertions(+)

diff --git a/core/src/main/resources/hudson/PluginManager/advanced.jelly b/core/src/main/resources/hudson/PluginManager/advanced.jelly
index caa86089f20d..8cf57a9ddc3b 100644
--- a/core/src/main/resources/hudson/PluginManager/advanced.jelly
+++ b/core/src/main/resources/hudson/PluginManager/advanced.jelly
@@ -32,6 +32,7 @@ THE SOFTWARE.
         <j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}"/>
 
         <st:include page="sidepanel.jelly"/>
+        <l:breadcrumb title="${%Advanced settings}" />
 
         <l:main-panel>
           <l:app-bar title="${%Advanced settings}"/>
diff --git a/core/src/main/resources/hudson/PluginManager/available.jelly b/core/src/main/resources/hudson/PluginManager/available.jelly
index 71f3cec29af9..a26a7953f536 100644
--- a/core/src/main/resources/hudson/PluginManager/available.jelly
+++ b/core/src/main/resources/hudson/PluginManager/available.jelly
@@ -29,6 +29,7 @@ THE SOFTWARE.
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:f="/lib/form">
   <l:layout title="${%Available plugins} - ${%Plugin Manager}" permission="${app.SYSTEM_READ}">
     <st:include page="sidepanel.jelly"/>
+    <l:breadcrumb title="${%Available plugins}" />
 
     <l:main-panel>
       <l:app-bar title="${%Plugins}" />
diff --git a/core/src/main/resources/hudson/PluginManager/installed.jelly b/core/src/main/resources/hudson/PluginManager/installed.jelly
index 0b63274662bb..28b6355e90c0 100644
--- a/core/src/main/resources/hudson/PluginManager/installed.jelly
+++ b/core/src/main/resources/hudson/PluginManager/installed.jelly
@@ -31,6 +31,7 @@ THE SOFTWARE.
     <j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}"/>
 
     <st:include page="sidepanel.jelly"/>
+    <l:breadcrumb title="${%Installed plugins}" />
 
     <l:main-panel>
       <l:app-bar title="${%Plugins}" />
diff --git a/core/src/main/resources/hudson/PluginManager/table.jelly b/core/src/main/resources/hudson/PluginManager/table.jelly
index 55ebb4f3946b..abdbeedef241 100644
--- a/core/src/main/resources/hudson/PluginManager/table.jelly
+++ b/core/src/main/resources/hudson/PluginManager/table.jelly
@@ -38,6 +38,7 @@ THE SOFTWARE.
   </st:documentation>
   <l:layout title="${%Updates} - ${%Plugin Manager}" permission="${app.SYSTEM_READ}">
     <st:include page="sidepanel.jelly"/>
+    <!-- no need for breadcrumb here -->
 
     <l:main-panel>
       <l:app-bar title="${%Plugins}" />

From 4262be91b63638243f8d2577893fb946dfda997c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Herv=C3=A9=20Le=20Meur?=
 <91831478+lemeurherve@users.noreply.github.com>
Date: Thu, 8 Dec 2022 16:20:29 +0100
Subject: [PATCH 2/3] better no breadcrumb comment

---
 core/src/main/resources/hudson/PluginManager/table.jelly | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/main/resources/hudson/PluginManager/table.jelly b/core/src/main/resources/hudson/PluginManager/table.jelly
index abdbeedef241..d71647dbd30f 100644
--- a/core/src/main/resources/hudson/PluginManager/table.jelly
+++ b/core/src/main/resources/hudson/PluginManager/table.jelly
@@ -38,7 +38,7 @@ THE SOFTWARE.
   </st:documentation>
   <l:layout title="${%Updates} - ${%Plugin Manager}" permission="${app.SYSTEM_READ}">
     <st:include page="sidepanel.jelly"/>
-    <!-- no need for breadcrumb here -->
+    <!-- no need for additional breadcrumb here as we're on an "index" page already including breadcrumb -->
 
     <l:main-panel>
       <l:app-bar title="${%Plugins}" />

From 7e13063d0eba49efc93dde6f7566cfd27d0dc981 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Herv=C3=A9=20Le=20Meur?= <hlemeur@cloudbees.com>
Date: Fri, 13 Jan 2023 18:17:00 +0100
Subject: [PATCH 3/3] Replace breadcrumbs by a comment

---
 core/src/main/resources/hudson/PluginManager/advanced.jelly  | 2 +-
 core/src/main/resources/hudson/PluginManager/available.jelly | 2 +-
 core/src/main/resources/hudson/PluginManager/installed.jelly | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/core/src/main/resources/hudson/PluginManager/advanced.jelly b/core/src/main/resources/hudson/PluginManager/advanced.jelly
index 8cf57a9ddc3b..4daaaf77b882 100644
--- a/core/src/main/resources/hudson/PluginManager/advanced.jelly
+++ b/core/src/main/resources/hudson/PluginManager/advanced.jelly
@@ -32,7 +32,7 @@ THE SOFTWARE.
         <j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}"/>
 
         <st:include page="sidepanel.jelly"/>
-        <l:breadcrumb title="${%Advanced settings}" />
+        <!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->
 
         <l:main-panel>
           <l:app-bar title="${%Advanced settings}"/>
diff --git a/core/src/main/resources/hudson/PluginManager/available.jelly b/core/src/main/resources/hudson/PluginManager/available.jelly
index a26a7953f536..480e49d8d17c 100644
--- a/core/src/main/resources/hudson/PluginManager/available.jelly
+++ b/core/src/main/resources/hudson/PluginManager/available.jelly
@@ -29,7 +29,7 @@ THE SOFTWARE.
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:f="/lib/form">
   <l:layout title="${%Available plugins} - ${%Plugin Manager}" permission="${app.SYSTEM_READ}">
     <st:include page="sidepanel.jelly"/>
-    <l:breadcrumb title="${%Available plugins}" />
+    <!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->
 
     <l:main-panel>
       <l:app-bar title="${%Plugins}" />
diff --git a/core/src/main/resources/hudson/PluginManager/installed.jelly b/core/src/main/resources/hudson/PluginManager/installed.jelly
index 28b6355e90c0..1d15c2a6dffa 100644
--- a/core/src/main/resources/hudson/PluginManager/installed.jelly
+++ b/core/src/main/resources/hudson/PluginManager/installed.jelly
@@ -31,7 +31,7 @@ THE SOFTWARE.
     <j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}"/>
 
     <st:include page="sidepanel.jelly"/>
-    <l:breadcrumb title="${%Installed plugins}" />
+    <!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->
 
     <l:main-panel>
       <l:app-bar title="${%Plugins}" />