From 21e275080b4b00d2daf122831aeabb6cea940e10 Mon Sep 17 00:00:00 2001
From: Tim Jacomb <timjacomb1@gmail.com>
Date: Sat, 13 Jul 2024 23:23:04 +0100
Subject: [PATCH 1/2] Disable dependents toggle in plugin manager with system
 read

---
 .../hudson/PluginManager/installed.jelly      | 102 +++++++++---------
 1 file changed, 49 insertions(+), 53 deletions(-)

diff --git a/core/src/main/resources/hudson/PluginManager/installed.jelly b/core/src/main/resources/hudson/PluginManager/installed.jelly
index 3c3ee43e0193..16d48e425d1f 100644
--- a/core/src/main/resources/hudson/PluginManager/installed.jelly
+++ b/core/src/main/resources/hudson/PluginManager/installed.jelly
@@ -170,56 +170,52 @@ THE SOFTWARE.
                   <l:isAdmin>
                     <td class="jenkins-table__cell--tight">
                       <div class="jenkins-table__cell__button-wrapper">
-                        <j:if test="${p.downgradable}">
-                          <form method="post"
-                                class="jenkins-buttons-row"
-                                action="${rootURL}/updateCenter/plugin/${p.shortName}/downgrade">
-                            <button class="jenkins-button jenkins-button--tertiary jenkins-!-color-orange"
-                                    style="padding: 0.5rem"
-                                    tooltip="${%downgradeTo(p.backupVersion)}">
-                              <l:icon src="symbol-downgrade-circle"/>
-                              <span style="white-space: nowrap; overflow: hidden; text-overflow: ellipsis; max-width: 60px;">
-                                ${p.backupVersion}
-                              </span>
-                            </button>
-                          </form>
-                        </j:if>
+                          <j:if test="${p.downgradable}">
+                            <form method="post"
+                                  class="jenkins-buttons-row"
+                                  action="${rootURL}/updateCenter/plugin/${p.shortName}/downgrade">
+                              <button class="jenkins-button jenkins-button--tertiary jenkins-!-color-orange"
+                                      style="padding: 0.5rem"
+                                      tooltip="${%downgradeTo(p.backupVersion)}">
+                                <l:icon src="symbol-downgrade-circle"/>
+                                <span
+                                    style="white-space: nowrap; overflow: hidden; text-overflow: ellipsis; max-width: 60px;">
+                                  ${p.backupVersion}
+                                </span>
+                              </button>
+                            </form>
+                          </j:if>
                       </div>
                     </td>
-                    <td class="jenkins-table__cell--tight uninstall">
-                      <div class="jenkins-table__cell__button-wrapper">
-                        <j:choose>
-                          <j:when test="${p.isDeleted()}">
-                            <p>${%Uninstallation pending}</p>
-                          </j:when>
-                          <j:otherwise>
-                            <j:if test="${p.hasMandatoryDependents() or p.hasImpliedDependents()}">
-                              <div class="dependent-list">
-                                <j:forEach var="dependent" items="${p.mandatoryDependents}">
-                                  <span data-plugin-id="${dependent}"></span>
-                                </j:forEach>
-                                <j:set var="impliedDependents" value="${p.impliedDependents}"/>
-                                <j:choose>
-                                  <j:when test="${impliedDependents.size() lt 15}">
-                                    <j:forEach var="dependent" items="${impliedDependents}">
-                                      <span data-plugin-id="${dependent}"></span>
-                                    </j:forEach>
-                                  </j:when>
-                                  <j:otherwise>
-                                    <p>
-                                      ${%detached-many-dependents(impliedDependents.size())}
-                                    </p>
-                                  </j:otherwise>
-                                </j:choose>
-                              </div>
-                            </j:if>
-                            <j:if test="${p.hasMandatoryDependencies()}">
-                              <div class="dependency-list">
-                                <j:forEach var="dependency" items="${p.mandatoryDependencies}">
-                                  <span data-plugin-id="${dependency.shortName}"></span>
-                                </j:forEach>
-                              </div>
-                            </j:if>
+                  </l:isAdmin>
+                  <td class="jenkins-table__cell--tight uninstall ${readOnlyMode and !p.isDeleted() ? 'jenkins-hidden' : ''}">
+                    <div class="jenkins-table__cell__button-wrapper">
+                      <j:choose>
+                        <j:when test="${p.isDeleted()}">
+                          <p>${%Uninstallation pending}</p>
+                        </j:when>
+                        <j:otherwise>
+                          <j:if test="${p.hasMandatoryDependents() or p.hasImpliedDependents()}">
+                            <div class="dependent-list">
+                              <j:forEach var="dependent" items="${p.mandatoryDependents}">
+                                <span data-plugin-id="${dependent}" />
+                              </j:forEach>
+                              <j:set var="impliedDependents" value="${p.impliedDependents}"/>
+                              <j:choose>
+                                <j:when test="${impliedDependents.size() lt 15}">
+                                  <j:forEach var="dependent" items="${impliedDependents}">
+                                    <span data-plugin-id="${dependent}" />
+                                  </j:forEach>
+                                </j:when>
+                                <j:otherwise>
+                                  <p>
+                                    ${%detached-many-dependents(impliedDependents.size())}
+                                  </p>
+                                </j:otherwise>
+                              </j:choose>
+                            </div>
+                          </j:if>
+                          <l:isAdmin>
                             <button data-action="uninstall"
                                     type="button"
                                     class="jenkins-button jenkins-button--tertiary jenkins-!-destructive-color"
@@ -228,11 +224,11 @@ THE SOFTWARE.
                                     data-message="${%uninstall-title(p.updateInfo.displayName ?: p.displayName)}">
                               <l:icon src="symbol-close-circle"/>
                             </button>
-                          </j:otherwise>
-                        </j:choose>
-                      </div>
-                    </td>
-                  </l:isAdmin>
+                          </l:isAdmin>
+                        </j:otherwise>
+                      </j:choose>
+                    </div>
+                  </td>
                 </tr>
               </j:forEach>
               <!-- failed ones -->

From 96b4e88d23faf63df80cf600da61e628b81bba93 Mon Sep 17 00:00:00 2001
From: Tim Jacomb <timjacomb1@gmail.com>
Date: Mon, 26 Aug 2024 12:20:35 +0100
Subject: [PATCH 2/2] Re-add dependency list

---
 .../resources/hudson/PluginManager/_table.js  | 33 ++++++++++---------
 .../hudson/PluginManager/installed.jelly      |  7 ++++
 2 files changed, 25 insertions(+), 15 deletions(-)

diff --git a/core/src/main/resources/hudson/PluginManager/_table.js b/core/src/main/resources/hudson/PluginManager/_table.js
index 8174fa1e833d..4806c3f573bb 100644
--- a/core/src/main/resources/hudson/PluginManager/_table.js
+++ b/core/src/main/resources/hudson/PluginManager/_table.js
@@ -504,24 +504,27 @@ window.addEventListener("load", function () {
     });
   });
 
-  // Enable/disable the 'Update' button depending on if any updates are checked
-  const anyCheckboxesSelected = () => {
-    return (
-      document.querySelectorAll("input[type='checkbox']:checked:not(:disabled)")
-        .length > 0
-    );
-  };
   const updateButton = document.querySelector("#button-update");
-  const checkboxes = document.querySelectorAll(
-    "input[type='checkbox'], [data-select], .jenkins-table__checkbox",
-  );
-  checkboxes.forEach((checkbox) => {
-    checkbox.addEventListener("click", () => {
-      setTimeout(() => {
-        updateButton.disabled = !anyCheckboxesSelected();
+  if (updateButton) {
+    // Enable/disable the 'Update' button depending on if any updates are checked
+    const anyCheckboxesSelected = () => {
+      return (
+        document.querySelectorAll(
+          "input[type='checkbox']:checked:not(:disabled)",
+        ).length > 0
+      );
+    };
+    const checkboxes = document.querySelectorAll(
+      "input[type='checkbox'], [data-select], .jenkins-table__checkbox",
+    );
+    checkboxes.forEach((checkbox) => {
+      checkbox.addEventListener("click", () => {
+        setTimeout(() => {
+          updateButton.disabled = !anyCheckboxesSelected();
+        });
       });
     });
-  });
+  }
 
   // Show update center error if element exists
   const updateCenterError = document.querySelector("#update-center-error");
diff --git a/core/src/main/resources/hudson/PluginManager/installed.jelly b/core/src/main/resources/hudson/PluginManager/installed.jelly
index 16d48e425d1f..951e0cf2877d 100644
--- a/core/src/main/resources/hudson/PluginManager/installed.jelly
+++ b/core/src/main/resources/hudson/PluginManager/installed.jelly
@@ -99,6 +99,13 @@ THE SOFTWARE.
                         </span>
                       </a>
                     </div>
+                    <j:if test="${p.hasMandatoryDependencies()}">
+                      <div class="dependency-list">
+                        <j:forEach var="dependency" items="${p.mandatoryDependencies}">
+                          <span data-plugin-id="${dependency.shortName}" />
+                        </j:forEach>
+                      </div>
+                    </j:if>
                     <div class="jenkins-!-margin-top-1">
                       <j:set var="indexPage" value="${p.indexPage.toString()}"/>
                       <j:set var="excerpt"