Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assertj and update pom #166

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Remove assertj and update pom #166

merged 1 commit into from
Mar 14, 2023

Conversation

jonesbusy
Copy link
Contributor

@jonesbusy jonesbusy commented Mar 12, 2023 •
edited
Loading

Remove assertj as it doesn't bring a lot of values and cause more issue with upperBounds in test dependencies

Also include #165 and #158 and #156

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@jonesbusy jonesbusy requested a review from a team as a code owner March 12, 2023 14:00
@jonesbusy jonesbusy marked this pull request as draft March 12, 2023 14:00
@jonesbusy jonesbusy marked this pull request as ready for review March 12, 2023 17:34
@repolevedavaj repolevedavaj merged commit 5e7c646 into jenkinsci:main Mar 14, 2023
@jonesbusy jonesbusy deleted the feature/remove-assertj branch March 14, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@repolevedavaj repolevedavaj repolevedavaj approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonesbusy @repolevedavaj