[JENKINS-69658] - failed-test.jelly javascript un-inlined.

[Artmorse]

The issue
You can find all the issue details here.

My updates
I've moved the onclick calls from the failed-test.jelly file to the failureSummary.js one.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[yaroslavafenkin]

document.URL is wrong, as it refers to that page we're in. Request has to go to JENKINS_URL/job/fs/5/testReport/<package_name>/<test_name>/summary and not just JENKINS_URL/job/fs/5/testReport/summary
Currently this returns 404:

[Artmorse]

Ok, can you please complete the Reproduction steps section of the Jira ticket (JENKINS-69658) description ?

[Artmorse]

ping @yaroslavafenkin

[yaroslavafenkin]

@Artmorse commented in the ticket

[Artmorse]

Perfect! I was able to do my tests! 😄

[Artmorse]

@yaroslavafenkin
Can you add the hacktoberfest-accepted label to this PR if it's seems good to you ? 😊

[yaroslavafenkin]

Still does not work as expected.

Request URL still looks wrong:

Providing steps I used:

1. Create a freestyle project
2. Select Git as SCM, as repository URL specify https://github.com/yaroslavafenkin/security-notifier.git. As branch specifier put */fail.
3. Add 'Invoke top-level Maven targets' build step. As goal set test.
4. Add 'Publish JUnit test result report' post-build action. As fileset includes put **/*.xml.
5. Save it and trigger a build.
6. When it fails go to the build and then to 'Test Result' action.
7. Open browser developer tools and go under 'All Failed Tests' hit the plus icon to obtain details about the failed test. You'll see failed request in the console, and should see an error as on the screenshot above.

[Kevin-CB]

Hey @Artmorse, I tried reviewing this PR and followed Yaroslav's steps. I'm not encountering any errors, it's working as expected.

However, I noticed that we missed to report an occurrence of inline JS (summary.jelly#L34-L35)
It's in a different class, but closely related to your changes, so if you're still willing to work on this topic, I'd be here to review it once more and help get it finally merged!

[Artmorse]

hey @Kevin-CB, yes I'll make the changes and I'll ping you when it's done!