Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-69658] - failed-test.jelly javascript un-inlined. #451

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[JENKINS-69658] - failed-test.jelly javascript un-inlined. #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a27bbb3
[JENKINS-69658] - failed-test.jelly javascript un-inlined.
Artmorse Oct 24, 2022
7e1486a
[JENKINS-69658] - failed-test.jelly javascript improved!
Artmorse Oct 31, 2022
31197c6
[JENKINS-69658] - Merge branch 'master' into JENKINS-69658
Artmorse May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/main/resources/lib/hudson/test/failed-test.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,13 @@ THE SOFTWARE.
}
</style>
</st:once>

<j:set var="id" value="${h.htmlAttributeEscape(url)}"/>
<j:set var="idjs" value="${h.jsStringEscape(url)}"/>
<j:set var="open" value="showFailureSummary('test-${h.jsStringEscape(id)}','${idjs}/summary')"/>
<j:set var="close" value="hideFailureSummary('test-${h.jsStringEscape(id)}')"/>
<a id="test-${id}-showlink" onclick="${open}" title="${%Show details}">

<a id="test-${id}-showlink" title="${%Show details}">
<l:icon src="symbol-add-outline plugin-ionicons-api" class="icon-sm"/>
</a>
<a id="test-${id}-hidelink" onclick="${close}" title="${%Hide details}" style="display:none">
<a id="test-${id}-hidelink" title="${%Hide details}" style="display:none">
<l:icon src="symbol-remove-outline plugin-ionicons-api" class="icon-sm"/>
</a>
<st:nbsp/>
Expand Down
53 changes: 44 additions & 9 deletions src/main/resources/lib/hudson/test/js/failureSummary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,55 @@

function showFailureSummary(id,query) {
var element = document.getElementById(id)
const PREFIX = "test-";
const SHOWLINK_SUFFIX = "-showlink";
const HIDELINK_SUFFIX = "-hidelink";

function showFailureSummary(summaryId, query) {
let element = document.getElementById(summaryId);

element.style.display = "";
document.getElementById(id + "-showlink").style.display = "none";
document.getElementById(id + "-hidelink").style.display = "";
document.getElementById(summaryId + SHOWLINK_SUFFIX).style.display = "none";
document.getElementById(summaryId + HIDELINK_SUFFIX).style.display = "";

if (typeof query !== 'undefined') {
var rqo = new XMLHttpRequest();
let rqo = new XMLHttpRequest();
rqo.open('GET', query, true);
rqo.onreadystatechange = function() { element.innerHTML = rqo.responseText; }
rqo.send(null);
}
}

function hideFailureSummary(id) {
document.getElementById(id).style.display = "none";
document.getElementById(id + "-showlink").style.display = "";
document.getElementById(id + "-hidelink").style.display = "none";
function hideFailureSummary(summaryId) {
document.getElementById(summaryId).style.display = "none";
document.getElementById(summaryId + SHOWLINK_SUFFIX).style.display = "";
document.getElementById(summaryId + HIDELINK_SUFFIX).style.display = "none";
}


document.addEventListener('DOMContentLoaded', () => {

// add the onclick behavior for all the "showlinks"
const testShowlinks = document.querySelectorAll("a[id*=test-][id*=-showlink]");
testShowlinks.forEach((element) => {
element.onclick = (_) => {
console.log("testShowlinks clicked");
const id = element.id.replace(PREFIX, '').replace(SHOWLINK_SUFFIX, '');
const summaryId = PREFIX + id;
console.log(`testShowlinks url ${document.URL + id + 'summary'}`);
showFailureSummary(summaryId, document.URL + id + "summary");
}
});

// add the onclick behavior for all the "hidelinks"
const testHidelinks = document.querySelectorAll("a[id*=test-][id*=-hidelink]");
testHidelinks.forEach((element) => {
element.onclick = (_) => {
console.log("testHidelinks clicked");
const id = element.id.replace(PREFIX, '').replace(HIDELINK_SUFFIX, '');
const summaryId = PREFIX + id;
hideFailureSummary(summaryId);
}
});

console.log("listeners added");

});