Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to specify a name of the port in services will be created by Jenkins Operator #736

Closed
take-a27 opened this issue Apr 6, 2022 · 2 comments · May be fixed by #801
Closed

unable to specify a name of the port in services will be created by Jenkins Operator #736

take-a27 opened this issue Apr 6, 2022 · 2 comments · May be fixed by #801
Labels
enhancement New feature or request stale
Milestone
0.9

Comments

@take-a27
Copy link

take-a27 commented Apr 6, 2022

Currently, Jenkins operator is not allowed to specify the name of port in the service which will be created by Jenkins Operator. I understood from this page.

So I'd like you to enable to specify the name of port in the service or create the service with named port.

  ports:
  -  name: http
     port: 8080
     protocol: TCP
     targetPort: 8080

The reason is that I'd like to use this feature of Istio. Thank you.
@take-a27 take-a27 added the enhancement New feature or request label Apr 6, 2022
@brokenpip3 brokenpip3 added the good first issue Good for newcomers label Mar 1, 2023
@brokenpip3
Copy link
Collaborator

Yup make sense.
This is a very "good first issue" if you want to try to fix it with a PR, we just need a small change in the helm chart template.

@brokenpip3 brokenpip3 added this to the 0.8 milestone Mar 1, 2023
@sonali-rajput sonali-rajput mentioned this issue Mar 6, 2023
Open
3 tasks
@brokenpip3 brokenpip3 removed the good first issue Good for newcomers label Mar 7, 2023
@brokenpip3 brokenpip3 modified the milestones: 0.8, 0.9 Mar 7, 2023
@brokenpip3
Copy link
Collaborator

Removing it from good-first-issue because I double check the code today and will needs to add the service name in the go struct and handle it in the pod creation. Finally the helm chart change.

@github-actions github-actions bot added the stale label May 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request stale
Projects
None yet
Milestone
0.9
Development

Successfully merging a pull request may close this issue.

Add variable to enable to specify the name of port in the service sonali-rajput/kubernetes-operator
2 participants
@brokenpip3 @take-a27