Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prepare-shutdown feature #999

Open
toabi opened this issue Apr 12, 2024 · 2 comments
Open

Use prepare-shutdown feature #999

toabi opened this issue Apr 12, 2024 · 2 comments
Labels
enhancement New feature or request not-stale
Milestone

Comments

@toabi
Copy link

toabi commented Apr 12, 2024

When a restart is necessary because of plugin upgrades or other configuration, jenkins should be restarted as gracefully as possible.

It could enable shutdown mode (in the UI under /manage/prepareShutdown/) and then wait until all jobs are done and then recreate the pod.

@toabi toabi added the enhancement New feature or request label Apr 12, 2024
@brokenpip3
Copy link
Collaborator

Yeah could be a great improvement. however:

  • right now the operator does not restart the pod if a new plugins version is present (was like that in the past, we changed the behavior)
  • in these weeks my free time is super limited so I need to continue the work with the more urgent tasks but I will find the time if a PR around this will be created :)

@toabi
Copy link
Author

toabi commented Apr 16, 2024

Ah, thanks for the answer :)

We actually wondered why the operator doesn't auto-restart the pod. For now with that new behaviour we can manually do this process with a graceful restart. It's not a top priority.

@brokenpip3 brokenpip3 added this to the 0.10 milestone Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not-stale
Projects
None yet
Development

No branches or pull requests

2 participants