Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include css file once #840

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

timja
Copy link
Member

@timja timja commented Mar 8, 2021

I noticed it included many times on the run summary view

I noticed it included many times on the run summary view
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #840 (bbef38f) into master (d1f363c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #840   +/-   ##
=========================================
  Coverage     80.20%   80.20%           
  Complexity     1561     1561           
=========================================
  Files           243      243           
  Lines          5664     5664           
  Branches        422      422           
=========================================
  Hits           4543     4543           
  Misses          965      965           
  Partials        156      156           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f363c...bbef38f. Read the comment docs.

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I did not know that we have such a flag 👍

I need to check the trend charts as well, maybe I am loading the same JS files multiple times as well.

@uhafner uhafner merged commit 685cfb6 into jenkinsci:master Mar 8, 2021
@uhafner uhafner added the bug Bugs or performance problems label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants