Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 3.3.X breaks support for gradle < v4.0 #95

Closed
milo-minderbinder opened this issue Aug 9, 2018 · 2 comments
Closed

release 3.3.X breaks support for gradle < v4.0 #95

milo-minderbinder opened this issue Aug 9, 2018 · 2 comments
Labels

Comments

@milo-minderbinder
Copy link

Obviously since Gradle 3.3 was released in Jan 2017, that may not be a huge issue [1], but it might be worth documenting so that users aren't confused when updating the plugin version breaks their build. As far as I can tell from a quick glance, the breaking change was here due to use of the org.gradle.api.attributes.Attribute class, which was introduced in Gradle version 3.3

[1]: YMMV, but in my experience, way too many projects rarely, if ever, update their gradle wrapper unless something breaks, so I still see Gradle 2.X quite often.

@milo-minderbinder milo-minderbinder changed the title release 3.X.X breaks support for gradle < v3.3 release 3.3.X breaks support for gradle < v3.3 Aug 10, 2018
@jeremylong
Copy link
Collaborator

It looks like the current minimum version of gradle for dependency-check-gradle 3.3.x is 4.0. I'm debating putting the older dependency resolution back in and use it when the gradle version is less then 4.0 or just saying the minimum gradle version is 4.0.

@jeremylong jeremylong changed the title release 3.3.X breaks support for gradle < v3.3 release 3.3.X breaks support for gradle < v4.0 Aug 10, 2018
jeremylong added a commit that referenced this issue Aug 10, 2018
@lock
Copy link

lock bot commented Oct 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Oct 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants