Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including package name in S3 class name(s)? #13

Open
rogiersbart opened this issue May 8, 2024 · 1 comment · May be fixed by #14
Open

Consider including package name in S3 class name(s)? #13

rogiersbart opened this issue May 8, 2024 · 1 comment · May be fixed by #14

Comments

@rogiersbart
Copy link

Since the renaming of the {scales} S3 class to "transform", it clashes with e.g. {raylibr}'s S3 class. The print() method is defined in both packages, and generates a warning, but certain methods from {raylibr} not defined in {scales}, break {scales} and therefore {ggplot2}. In the reprex below, in particular, S3method("$",transform) from {raylibr} is responsible. As {scales} and {ggplot2} are widely used, and it seems to be recommended to include the package name in S3 class names (well, at least according to Advanced R), maybe it would be useful to consider including the package name in the S3 class names? I'm not sure how straightforward this would be however, as I believe most of {raylibr}'s code was generated automatically to wrap {raylib} through {Rcpp} ... ?

library(raylibr)
#> 
#> Attaching package: 'raylibr'
#> The following object is masked from 'package:base':
#> 
#>     transform
library(ggplot2)
#> Registered S3 method overwritten by 'scales':
#>   method          from   
#>   print.transform raylibr
ggplot2::ggplot(cars) +
  ggplot2::aes(speed, dist) +
  ggplot2::geom_point()
#> Error:
#> ! `transform` has no property transform.

Created on 2024-05-08 with reprex v2.1.0

@rogiersbart
Copy link
Author

See also r-lib/scales#430.

@rogiersbart rogiersbart linked a pull request May 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant