From 8ad60bf60c79a82ffbefefadf6958507599d924a Mon Sep 17 00:00:00 2001
From: Jerem <jersou@gmail.com>
Date: Mon, 10 Apr 2023 11:51:02 +0200
Subject: [PATCH] fix: add doc to set rw permission on /dev/uinput #1

See
https://github.com/pwr-Solaar/Solaar/pull/1607
https://github.com/ValveSoftware/steam-for-linux/issues/4794
---
 README.md   | 37 +++++++++++++++++++++++++++++++------
 src/main.rs |  5 ++++-
 2 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/README.md b/README.md
index 716a3f7..4f5e5fb 100644
--- a/README.md
+++ b/README.md
@@ -65,15 +65,39 @@ cargo build --release
 
 ### Requirement :
 
-To use the main feature "grab event", you need to add the current user
-to `input` & `plugdev` group :
+To use the main feature "grab event", you need to have the read&write permission
+on /dev/input/event*. Check the group of `/dev/input/event*` files :
 
+```bash
+ls -al /dev/input/event*
+# > crw-rw---- 1 root input /dev/input/event5
+#                     ^^^^^
 ```
+
+You need to add the current user to this group, usually `input` or `plugdev` :
+
+```bash
 sudo usermod -a -G plugdev $USER
+# or
 sudo usermod -a -G input $USER
 ```
 
-You need to restart your desktop session to apply this user changes.
+Furthermore, you must have the R/W right on /dev/uinput, you can check with:
+
+```bash
+getfacl /dev/uinput
+# ...
+# user:<the current user>:rw-
+# ...
+```
+
+If this permission is not available on the user, to add it temporary : `sudo setfacl -m u:$USER:rw /dev/uinput` or persistent :
+
+```bash
+sudo tee /etc/udev/rules.d/80-mouse-actions.rules <<<'KERNEL=="uinput", SUBSYSTEM=="misc", TAG+="uaccess", OPTIONS+="static_node=uinput"'
+```
+
+You need to restart your desktop session to apply these changes.
 
 To check the user groups:
 
@@ -332,10 +356,8 @@ cargo build --release
 
 ### High
 
-* fix #1: permission denied on Xubuntu 22.04 without sudo
 * fix exec cmd
   error `Err(Os { code: 2, kind: NotFound, message: "No such file or directory" })`
-* a release 0.3.0
 * fix rdev
     * fix rdev devices delete/update: the FIXME "inotify CREATE but not DELETE
       in grab::inotify_devices()" in rdev/src/linux/grab.rs:493
@@ -351,9 +373,12 @@ cargo build --release
 
 ### Medium
 
+* dry-run option
+* min diff shape option
+* min score shape option
 * check $XDG_SESSION_TYPE == "x11"/"wayland" to trace/enable --no-listen option
 * backup the config before save (record)
-* POC : config editor server with deno
+* POC : config editor server with deno fresh
 * use https://github.com/hoodie/notify-rust
 * don't use arrayvec ?
 * process TODO and FIXME
diff --git a/src/main.rs b/src/main.rs
index 2ac9414..d70f1e9 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -114,7 +114,10 @@ fn main() {
                     error!("The user must be in the file group of {DEV_PATH} files, usually 'input' or 'plugdev' :");
                     error!("  $ sudo usermod -a -G input $USER");
                     error!("  $ sudo usermod -a -G plugdev $USER");
-                    error!("Then restart the desktop session to apply this user modifications.");
+                    error!(
+                        r#"  $ sudo tee /etc/udev/rules.d/80-mouse-actions.rules <<<'KERNEL=="uinput", SUBSYSTEM=="misc", TAG+="uaccess", OPTIONS+="static_node=uinput"'"#
+                    );
+                    error!("Then restart to apply this user modifications.");
                 }
             }
         }