[prefer-snapshot-hint] is it supposed to warn on multiple snapshots in a different test but the same describe block?

[lostfictions]

Hey there, thanks for your quick work fixing #1068! Unfortunately, I'm still seeing an issue with prefer-snapshot-hint.

With "jest/prefer-snapshot-hint": ["warn", "multi"] set, this works fine:

describe("my cool test", () => {
  it("requires hints for a test with multiple snapshots", () => {
    expect(1).toMatchSnapshot("a cool hint");
    expect(2).toMatchSnapshot("another cool hint");
  });
});

This also works fine:

describe("my cool test", () => {
  it("doesn't require hints for a test with a single snapshot", () => {
    expect(2).toMatchSnapshot();
  });
});

However, this yields a warning:

describe("my cool test", () => {
  it("doesn't require hints for a test with a single snapshot", () => {
    expect(2).toMatchSnapshot();
    //        ^ Warning: You should provide a hint for this snapshot
  });

  it("requires hints for a test with multiple snapshots", () => {
    expect(1).toMatchSnapshot("a cool hint");
    expect(2).toMatchSnapshot("another cool hint");
  });
});

I see in the rule description there's a parenthetical "(meaning it includes nested calls)" -- is this what that means? The behaviour is a bit surprising to me -- I thought "nested calls" meant it would treat the scope as including all functions called from within an it() block, not all it() blocks within a describe() block.

[G-Rath]

Yup that's another bug - your thinking on what "nested calls" means is correct - the behaviour shouldn't change just because it gets wrapped in a describe like that.

[github-actions]

🎉 This issue has been resolved in version 26.1.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀