Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Our build process doesn't fail on TypeScript errors #43

Open
seanpoulter opened this issue May 2, 2020 · 0 comments
Open

Comments

@seanpoulter
Copy link
Member

One of our library consumers opened PR #42 because:

When trying to compile a Typescript project that depends on this library it was throwing an error


Expected behaviour
We catch TypeScript errors in our CI/CD pipeline

Actual behaviour
😞

Steps to reproduce the issue
- Revert PR #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant