-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest-resolve broken: getMockModule throws an error #10771
Comments
Should we just @FrontendMMA do you have a reproduction we can pull down and test? |
Sorry to see this regression! 😿
|
Can you reduce it down? Just delete all code except the test file, the file it resolves to and the minimal jest config needed? A try/catch is not the correct solution I'd think - we shouldn't throw in the first place |
https://github.com/FrontendMMA/jest-resolve--bug-example
|
Thanks @FrontendMMA! I had to change some stuff to make it work and understand where the regression was, I opened a PR: FrontendMMA/jest-resolve--bug-example#1 @brapifra would you be able to take a look at this? If you look at my branch it can be reproduced by removing the |
Yes, I will look into this tomorrow @SimenB |
Thanks! |
Fix released in https://github.com/facebook/jest/releases/tag/v26.6.3 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
💥 Regression Report
A clear and concise description of what the regression is.
Last working version
Worked up to version: 26.6.1
Stopped working in version: 26.6.2
To Reproduce
Steps to reproduce the behavior:
jest.config.js
throw error
Expected behavior
not throwed
Link to repl or repo (highly encouraged)
Run
npx envinfo --preset jest
I can fix the regex, but the problem persists for others
This error here https://github.com/facebook/jest/blob/master/packages/jest-resolve-dependencies/src/index.ts#L78
The text was updated successfully, but these errors were encountered: