Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages are linked incorrectly on windows #4135

Closed
aaronabramov opened this issue Jul 26, 2017 · 8 comments
Closed

packages are linked incorrectly on windows #4135

aaronabramov opened this issue Jul 26, 2017 · 8 comments
Labels

Comments

@aaronabramov
Copy link
Contributor

aaronabramov commented Jul 26, 2017

here's a repro build: https://ci.appveyor.com/project/Daniel15/jest/build/4207
PR: #4134

In the logs you can see that require.resolve('jest-config') returns :\projects\jest\node_modules\jest-config\build\index.js which seems to be the last published version of the package from npm.
locally and on circle/travis it resolves to jest/packages/jest-config/build/index.js, the local version of the file.

@thymikee
Copy link
Collaborator

Is it something we do wrong, or maybe a Lerna bug?

@cpojer
Copy link
Member

cpojer commented Jul 27, 2017

cc @bestander

@bestander
Copy link
Contributor

bestander commented Jul 27, 2017 via email

@bestander
Copy link
Contributor

@aaronabramov I don't have a windows PC at this moment.
I'll try to help diagnosing the problem if it is related to Yarn workspaces.

What does https://ci.appveyor.com/project/Daniel15/jest/build/4233 line 80-125 tell you?
This PR #4151.

@aaronabramov
Copy link
Contributor Author

@bestander seems like yarn update fixed the issue. line 129 prints out the path to the local package directory (unlike mine PR where it goes to node_moduels)
i'll make sure next time i'll try updating yarn first :)
i made a PR with a small change in package APIs to make sure tests are still passing #4154 and the build seems to be green

@thymikee
Copy link
Collaborator

thymikee commented Aug 4, 2017

Reopening, we have two PRs hitting that

@thymikee thymikee reopened this Aug 4, 2017
@cpojer
Copy link
Member

cpojer commented Aug 24, 2017

This belongs on the Yarn issue tracker.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants