Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify no tests found message when running MPR #4324

Closed
aaronabramov opened this issue Aug 22, 2017 · 6 comments · Fixed by #4354
Closed

Unify no tests found message when running MPR #4324

aaronabramov opened this issue Aug 22, 2017 · 6 comments · Fixed by #4354

Comments

@aaronabramov
Copy link
Contributor

currently, if there are no test found matching a pattern when running jest in Multi project runner mode we get a very noisy output for each separate project. we need to unify it into one single message for all projects.
example:

screen shot 2017-08-22 at 10 12 11 am

@rogeliog
Copy link
Contributor

I also find this super noisy

How about something like this?

In /path/to/root
  781 files checked across 8 projects. for more details run with `--verbose`

running with --verbose would give as similar output as today's behavior.

@rogeliog
Copy link
Contributor

rogeliog commented Aug 23, 2017

Unrelated note: Once displayName gets merged, it might be a good idea to add it to this output

In PROJECT_1 /some/path/to/project
  X files checked.
  testMatch: **/__tests__/**/*.js?(x),**/?(*.)(spec|test).js?(x) - X matches
  testPathIgnorePatterns: /node_modules/ - X matches

In PROJECT_2 /some/path/to/project2
  Y files checked.
  testMatch: **/__tests__/**/*.js?(x),**/?(*.)(spec|test).js?(x) - Y matches
  testPathIgnorePatterns: /node_modules/ - Y matches

@cpojer
Copy link
Member

cpojer commented Aug 23, 2017

Agree with @rogeliog, both of these suggestions make a lot of sense to me.

@chitchu
Copy link
Contributor

chitchu commented Aug 25, 2017

I'd like to work on this. I'll have the PR shortly.

@rogeliog
Copy link
Contributor

Awesome!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants