Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending items for the runner #4370

Closed
1 of 2 tasks
rogeliog opened this issue Aug 26, 2017 · 4 comments
Closed
1 of 2 tasks

Pending items for the runner #4370

rogeliog opened this issue Aug 26, 2017 · 4 comments

Comments

@rogeliog
Copy link
Contributor

rogeliog commented Aug 26, 2017

There are a couple of pending items

@SimenB
Copy link
Member

SimenB commented Mar 23, 2018

I think a really useful thing would be to move https://github.com/rogeliog/create-jest-runner/blob/master/lib/createJestRunner.js into Jest proper. There are a couple of PRs there (jest-community/create-jest-runner#5 and jest-community/create-jest-runner#6) that would have been gotten for free if the factory lived in Jest (and even the freshly landed #5860).

I think only the path to the function executing "tests" (https://github.com/facebook/jest/blob/1a487c1803124c594bdd86ee24b5949025660bc3/packages/jest-runner/src/index.js#L23 in Jest's case) needs to be injected, then it would be mostly the same API.

(note that the helpers of create-jest-runner would still remain there, it's just the factory creating an actual runner that would be moved)

@rogeliog
Copy link
Contributor Author

I think this is a really interesting idea

@thymikee
Copy link
Collaborator

Docs is already there, only the configuration left, so I'll close this umbrella issue :)

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants