Jest marks a test as "Passed" when an assertion fails on a .resolves

[Vinnl]

Do you want to request a feature or report a bug?

A bug.

What is the current behavior?

The following assertion fails:

expect(Promise.resolve('Expected value')).resolves.toBe('Not the expected value');

It throws an error, but nevertheless, Jest marks the test as Passed. See this repl.it:

https://repl.it/repls/ObedientNegativeGrison

What is the expected behavior?

Jest should mention that the test failed.

Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.

$ yarn run jest --version
v21.2.1

$ node --version
v6.11.3

$ yarn --version
1.3.2

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.3 LTS
Release:        16.04
Codename:       xenial

[SimenB]

You have to return (or await) the expect.

http://facebook.github.io/jest/docs/en/expect.html#resolves

[Vinnl]

Oh really? Ugh, sorry for wasting your time - I thought that requirement had been removed with the addition of .resolves.

[SimenB]

You still have to somehow tell jest to wait for it - it's still a promise 🙂

Difference now is that you await the expect itself, and not the value within it

[Vinnl]

Hehe yeah it makes sense. Gives me some bad faith about all those tests I've already written without this measure :P I could submit a PR to emphasise this in the docs if you think that's a good idea?

[SimenB]

Please do! All doc improvements are very welcome

[Vinnl]

@SimenB #4999 - almost at number 5000!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.