Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest-cli installations break when version is <=22.3.0 #5749

Closed
trevorharwell opened this issue Mar 7, 2018 · 2 comments
Closed

Jest-cli installations break when version is <=22.3.0 #5749

trevorharwell opened this issue Mar 7, 2018 · 2 comments

Comments

@trevorharwell
Copy link

trevorharwell commented Mar 7, 2018

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
New installations of jest-cli that use a version <=v22.3.0 break.
If you look at the package.json for any of the versions in that range the dependency version specified for jest-util is ^22.3.0 which will resolve to jest-util 22.x.x. As of jest-util version 22.4.0 a breaking change was added where the validateCLIOptions method was moved from jest-util to jest-validate. This is the PR and commit in question:

#5536
ba1366b#diff-c4d2f45d479f76f83c356be6fe8d74f9L50

What is the expected behavior?
That a backwards compatible version of jest-util exists in the 22.x.x version range.
I honestly think it might be better to use ~ instead of ^ on dependency versions so this sort of thing doesn't happen in the future.

@SimenB
Copy link
Member

SimenB commented Aug 14, 2018

Sorry about this, but we won't go back and fix it.

I honestly think it might be better to use ~ instead of ^ on dependency versions so this sort of thing doesn't happen in the future.

We could potentially lock down the deps from within this repo, they don't really need the range (jest and jest-cli would always point to the correct one for that version)

@SimenB SimenB closed this as completed Aug 14, 2018
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants