Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test in node 9.9.0 #5871

Closed
SimenB opened this issue Mar 26, 2018 · 2 comments
Closed

Failing test in node 9.9.0 #5871

SimenB opened this issue Mar 26, 2018 · 2 comments

Comments

@SimenB
Copy link
Member

SimenB commented Mar 26, 2018

Do you want to request a feature or report a bug?
Bug, I guess

What is the current behavior?
The test packages/jest-cli/src/__tests__/search_source.test.js fails using node 9.9.0, but passes on node 9.8.0 (and it also passes on node 6 and 8).

The test failing was added in #5224.

  ● SearchSource › testPathsMatching › finds tests with parentheses in their rootDir when using testMatch

    expect(received).toEqual(expected)

    Expected value to equal:
      [StringContaining "__testtests__/test.js"]
    Received:
      []

    Difference:

    - Expected
    + Received

    - Array [
    -   StringContaining "__testtests__/test.js",
    - ]
    + Array []

My shot in the dark is that somehow this regex has changed behavior: https://github.com/facebook/jest/blob/2bd5dfddfef425348760807d12348829a9a82d30/packages/jest-config/src/utils.js#L51-L53

If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can yarn install and yarn test.

N/A

What is the expected behavior?
It should pass on node 9.9.0 as well.

Please provide your exact Jest configuration

https://github.com/facebook/jest/tree/2bd5dfddfef425348760807d12348829a9a82d30

@SimenB
Copy link
Member Author

SimenB commented Mar 26, 2018

Fixed in node master: nodejs/node#19520

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant