Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Node.js 4 anymore due to Array.prototype.includes #7253

Closed
DanielRuf opened this issue Oct 23, 2018 · 4 comments
Closed

Comments

@DanielRuf
Copy link
Contributor

🐛 Bug Report

cefc342 broke Node.js 4 support as Array.prototype.includes is only in Node.js 6.5+ available.

To Reproduce

Use nodenv or nvm, switch to Node 4 and create a project with jest.

Steps to reproduce the behavior:

Expected behavior

Node.js should be supported.

Link to repl or repo (highly encouraged)

See https://travis-ci.org/docker/kitematic/builds/443616745

Issues without a reproduction link are likely to stall.

Run npx envinfo --preset jest

Paste the results here:

@SimenB
Copy link
Member

SimenB commented Oct 23, 2018

We dropped node 4 with Jest 22 back in December of last year https://jestjs.io/blog/2017/12/18/jest-22#good-bye-node-4-welcome-jsdom-11. The fact the code has worked on older nodes up until now is a coincidence

@SimenB SimenB closed this as completed Oct 23, 2018
@DanielRuf
Copy link
Contributor Author

Well but then it should have been set in the engines field to make this clear or increase the major version as kitematic builds worked before this change as it seems.

@SimenB
Copy link
Member

SimenB commented Oct 24, 2018

PR welcome! 🙂

@DanielRuf DanielRuf changed the title Not compatible with Node.js anymore due to Array.prototype.includes Not compatible with Node.js 4 anymore due to Array.prototype.includes Oct 24, 2018
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants