-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with Node.js 4 anymore due to Array.prototype.includes #7253
Comments
We dropped node 4 with Jest 22 back in December of last year https://jestjs.io/blog/2017/12/18/jest-22#good-bye-node-4-welcome-jsdom-11. The fact the code has worked on older nodes up until now is a coincidence |
Well but then it should have been set in the |
PR welcome! 🙂 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
🐛 Bug Report
cefc342 broke Node.js 4 support as Array.prototype.includes is only in Node.js 6.5+ available.
To Reproduce
Use nodenv or nvm, switch to Node 4 and create a project with jest.
Steps to reproduce the behavior:
Expected behavior
Node.js should be supported.
Link to repl or repo (highly encouraged)
See https://travis-ci.org/docker/kitematic/builds/443616745
Issues without a reproduction link are likely to stall.
Run
npx envinfo --preset jest
Paste the results here:
The text was updated successfully, but these errors were encountered: