getChangedFilesForRoots returns things that aren't files

[jumoel]

🐛 Bug Report

getChangedFilesForRoots in jest-changed-files returns things that aren't files.
More specifically, it returns lines from commit messages instead.

To Reproduce

$ git clone https://github.com/jumoel/jest-changed-files-bug
$ cd jest-changed-files-bug && yarn && node index.js

Verify that lines from the commit message are present in the output:

{ changedFiles:
   Set {
     '~/test/another line',
     '~/test/yet another one',
     '~/test/.gitignore',
     '~/test/index.js',
     '~/test/package.json',
     '~/test/yarn.lock' },
  repos: { git: Set { '~/test' }, hg: Set {} } }

Expected behavior

The changedFiles should not contain items that are not files (another line and yet another one specifically).

Link to repl or repo (highly encouraged)

https://github.com/jumoel/jest-changed-files-bug

Run npx envinfo --preset jest

Paste the results here:

  System:
    OS: macOS 10.14.3
    CPU: (4) x64 Intel(R) Core(TM) i5-7600 CPU @ 3.50GHz
  Binaries:
    Node: 10.14.1 - ~/.nvm/versions/node/v10.14.1/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.7.0 - ~/.nvm/versions/node/v10.14.1/bin/npm

[SimenB]

huh, weird we haven't noticed that? We probably do a file filter later inside of Jest. Wanna send a PR fixing it?

[jumoel]

Yep, wouldn't mind. 👍

One solution is to change the git command to --pretty="format:". Another is to do a file filter.

Which would you prefer?

[SimenB]

I don't have a preference, whatever's fastest/most readable 🙂

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.