Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactElement serializer does not support Suspense #8178

Closed
bvaughn opened this issue Mar 20, 2019 · 3 comments · Fixed by #8180
Closed

ReactElement serializer does not support Suspense #8178

bvaughn opened this issue Mar 20, 2019 · 3 comments · Fixed by #8180
Assignees
@scotthovestadt
Labels
🐛 Bug Bug Report

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Mar 20, 2019

The ReactElement is not aware of the React.Suspense component type, and as a result it causes snapshots to display "UNDEFINED". Fortunately it looks like this serializer is built on top of react-is which already exports a isSuspense so it should hopefully be easy to add this. 😄
@scotthovestadt scotthovestadt self-assigned this Mar 20, 2019
@scotthovestadt
Copy link
Contributor

I'll take care of it. Thanks for the bug report.

@scotthovestadt scotthovestadt mentioned this issue Mar 20, 2019
Merged
@SimenB
Copy link
Member

SimenB commented Mar 20, 2019

Fortunately it looks like this serializer is built on top of react-is which already exports a isSuspense so it should hopefully be easy to add this. 😄

Yeah, we migrated to it just a couple of weeks ago 🙂

#8060

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@scotthovestadt scotthovestadt

Labels
🐛 Bug Bug Report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support React.Suspense in snapshots. scotthovestadt/jest
3 participants
@bvaughn @SimenB @scotthovestadt