Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-resolve throws on network drives #8291

Closed
aliaksandr-yermalayeu opened this issue Apr 9, 2019 · 11 comments
Closed

jest-resolve throws on network drives #8291

aliaksandr-yermalayeu opened this issue Apr 9, 2019 · 11 comments

Comments

@aliaksandr-yermalayeu
Copy link

💥 Regression Report

Jest throws error while resolving cwd
>> Error: EISDIR: illegal operation on a directory, realpath 'G:\Build'

Last working version

23.6.0
Worked up to version:
23.6.0
Stopped working in version:
24.7.1 (or earlier in 24)

To Reproduce

Steps to reproduce the behavior:
please see detailed description in #6880

Expected behavior

It should not throw

@thymikee
Copy link
Collaborator

thymikee commented Apr 9, 2019

Since it's a Windows issue, and none of maintainers use it daily, we'd appreciate your help on that :)

@aliaksandr-yermalayeu
Copy link
Author

Sure, I'll create a pull request =)

@SimenB
Copy link
Member

SimenB commented Apr 9, 2019

@aliaksandr-yermalayeu I'd prefer to make realpath-native not throw in this case, mind sending a PR to https://github.com/SimenB/realpath-native? It's supposed to return its input if anything fails.

Is this SimenB/realpath-native#35 (which has an open PR)?

@aliaksandr-yermalayeu
Copy link
Author

aliaksandr-yermalayeu commented Apr 9, 2019

@SimenB,
While making the PR, I've found nearly ten cases of realpath usage in different jest dependencies. It seems really strange to me that half of them is wrapped with try-catch, and another half isn't.

@SimenB
Copy link
Member

SimenB commented Apr 9, 2019

Ideally none in Jest should be wrapped. At least as long as the fallback is using whatever they passed in as-is

@aliaksandr-yermalayeu
Copy link
Author

ok, I'll take a look

@aliaksandr-yermalayeu
Copy link
Author

@SimenB,
I tried https://github.com/rvaidya/realpath-native/tree/feature/windowsRamdiskTry2 and it works for me. If you are ok with @rvaidya changes, I may create a PR from his repo.

@SimenB
Copy link
Member

SimenB commented Apr 9, 2019

They opened up a PR now, I'll try to land and release it tomorrow

@heavenkiller2018
Copy link

no one to fix the only bug?oh, my god!

@SimenB
Copy link
Member

SimenB commented May 2, 2020

Hopefully fixed (although not released). Please check Jest 26 when we release it. If it's still not fixed, we might need to catch some more

@SimenB SimenB closed this as completed May 2, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants