Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchman: false in config file not respected (always true) #962

Closed
zpao opened this issue Apr 29, 2016 · 4 comments
Closed

watchman: false in config file not respected (always true) #962

zpao opened this issue Apr 29, 2016 · 4 comments

Comments

@zpao
Copy link
Contributor

zpao commented Apr 29, 2016

Since the CLI defaults watchman to true1, this will always override any value specified in the config2. Basically the check at 2 should be more nuanced or we shouldn't specify the default values when parsing argv and let it happen where we set other defaults.

@cpojer
Copy link
Member

cpojer commented Apr 30, 2016

Yes you are right, which is why I removed the config options from the API docs. The next version of Jest will retry a crawl with node instead of watchman if watchman is not available, so this should not be an issue any longer.

We keep the --no-watchman flag so that jest doesn't print a silly warning message every time – which should only happen if watchman is available but cannot be used, which is a rare case anyway. Does this make sense?

@cpojer cpojer closed this as completed Apr 30, 2016
@cpojer
Copy link
Member

cpojer commented Apr 30, 2016

(the fact that we use configs to transport options is bad and we should rewrite that.)

@zpao
Copy link
Contributor Author

zpao commented May 2, 2016

You're the one who used the config and not the command line flag 😛 facebook/react@681a463

I think the problem actually becomes worse than just a passive warning. For me I was getting the "no watchman found" error from sane and then it would just stop running.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants