Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code in IstanbulTestReporter. #1282

Merged
merged 1 commit into from
Jul 12, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions packages/jest-config/src/reporters/IstanbulTestReporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,13 @@ const FAIL_COLOR = chalk.bold.red;
class IstanbulTestReporter extends DefaultTestReporter {

_collector: istanbul.Collector;
_reporter: istanbul.Reporter;
_testCollectors: Object;

constructor(customProcess: Process) {
super(customProcess);

this._collector = new istanbul.Collector();
this._testCollectors = Object.create(null);
this._reporter = new istanbul.Reporter();
}

onTestResult(
Expand All @@ -54,8 +52,8 @@ class IstanbulTestReporter extends DefaultTestReporter {
onRunComplete(config: Config, aggregatedResults: AggregatedResult) {
aggregatedResults.success = super.onRunComplete(config, aggregatedResults);

const reporter = this._reporter;
if (config.collectCoverage) {
const reporter = new istanbul.Reporter();
try {
if (config.coverageDirectory) {
reporter.dir = config.coverageDirectory;
Expand Down Expand Up @@ -111,14 +109,6 @@ class IstanbulTestReporter extends DefaultTestReporter {
return aggregatedResults.success;
}

getReporter() {
return this._reporter;
}

getCollector() {
return this._collector;
}

getTestCollectors() {
return this._testCollectors;
}
Expand Down