Fix tests on Node 8.7 #4680
Merged
Fix tests on Node 8.7 #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for investigating! |
SimenB
reviewed
Oct 13, 2017
| @@ -162,7 +162,7 @@ const cleanupStackTrace = (output: string) => { | |||
| .replace(/\n.*at.*assert\.js.*$/gm, '') | |||
| .replace(/\n.*at.*node\.js.*$/gm, '') | |||
| .replace(/\n.*at.*next_tick\.js.*$/gm, '') | |||
| .replace(/\n.*at Promise \(<anonymous>\).*$/gm, '') | |||
| .replace(/\n.*at (new)? Promise \(<anonymous>\).*$/gm, '') | |||
There was a problem hiding this comment.
shouldn't this be (new )? (space after new)? Obviously it works, so maybe not :P
There was a problem hiding this comment.
You're right, didn't notice it broke older node 8 on circle 🤦♂️
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Node 8.7 brings extra
newbeforePromise(<anonymous>)in stack traces, so updated the regex accordingly.Test plan
Travis green