Enable single thread mode for runner #5712

DanielMSchmidt · 2018-03-03T12:31:06Z

Summary

Some runners for tools that can not be run in parallel need a way
to specify that they should not be executed in parallel. This commits
adds this functionality. This closes #5706

Test plan

Unit tests are included

SimenB

This needs a test.

Also. please update the changelog 🙂

SimenB · 2018-03-03T23:29:39Z

See CI for flow error (run yarn flow locally to see it)

DanielMSchmidt · 2018-03-04T17:50:21Z

@SimenB Somehow yarn flow has problems on my machine, I can not really tell why. I followed the contributing guide.

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ packages/jest/src/jest.js:10:17

Cannot resolve module jest-cli.

codecov-io · 2018-03-04T17:59:44Z

Codecov Report

Merging #5712 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5712      +/-   ##
==========================================
+ Coverage   63.65%   63.67%   +0.02%     
==========================================
  Files         216      216              
  Lines        7918     7918              
  Branches        4        4              
==========================================
+ Hits         5040     5042       +2     
+ Misses       2877     2875       -2     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-cli/src/test_scheduler.js	`27.92% <ø> (+1.29%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e82577...2862c29. Read the comment docs.

cpojer · 2018-03-05T00:00:34Z

docs/Configuration.md

@@ -703,6 +703,10 @@ async runTests(
 ): Promise<void>
 ```

+If you need to restrict your test-runner to only run in serial rather then being
+exectued in paralell your class should have the static attribute `serial` to be


can we call it isSerial?

typos:

exectued => executed

paralell => parallel

SimenB · 2018-03-05T07:52:48Z

Somehow yarn flow has problems on my machine

That's odd. Have you tried yarn clean-all && rm -rf node_modules && yarn? Sometimes it helps if the repo has gotten into a weird state. Make sure you're on yarn 1.3.2 or newer as well.

DanielMSchmidt · 2018-03-05T08:52:19Z

Thank you @SimenB, will try that our 👍

DanielMSchmidt · 2018-03-07T19:55:15Z

@SimenB Thank you for your help; I installed the dependencies with a different version of yarn.

As a general remark: I added unit tests but they "fail" because of a missing HasteFS that should be passed to the calls. It appeared to me as if I should have passed it through, but I was incapable of retrieving or mocking HasteFS (seems to be used in the jest-haste-map package, but not exposed).
I feel like there should be some more tests for this part if someone would provide a good example I would be able to contribute better tests.

SimenB · 2018-03-08T08:36:24Z

packages/jest-cli/src/test_scheduler.js

@@ -192,7 +192,7 @@ export default class TestScheduler {
            onResult,
            onFailure,
            {
-              serial: runInBand,
+              serial: runInBand || testRunners[runner].isSerial,


what about serial: runInBand || Boolean(testRunners[runner].isSerial) to ensure we always pass a boolean down?

sure, that makes sense 👍

dated

SimenB · 2018-03-08T08:37:44Z

@cpojer thoughts on the comments about testing and hastefs?

cpojer · 2018-03-08T09:34:47Z

We should definitely pass the right arguments to the function calls. There is a createHasteContext utility in Jest's tests for this purpose.

Some runners for tools that can not be run in parallel need a way to specify that they should not be executed in parallel. This commits adds this functionality. Closes jestjs#5706

DanielMSchmidt · 2018-03-08T10:57:48Z

I think I mocked the right things now 👍

cpojer · 2018-03-08T12:52:02Z

Nice!

DanielMSchmidt · 2018-03-08T12:54:56Z

Awesome, only 6 to go for a shirt 😂

cpojer · 2018-03-08T12:59:22Z

You only need 5 total for a tshirt. So one down, 4 to go. You can do it!

Some runners for tools that can not be run in parallel need a way to specify that they should not be executed in parallel. This commits adds this functionality. Closes jestjs#5706

github-actions · 2021-05-12T19:12:01Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

facebook-github-bot added the cla signed label Mar 3, 2018

SimenB previously requested changes Mar 3, 2018

View reviewed changes

DanielMSchmidt force-pushed the add-serial-flag-for-runner branch from 9e10710 to 63e9257 Compare March 4, 2018 17:46

DanielMSchmidt force-pushed the add-serial-flag-for-runner branch 2 times, most recently from dfe9545 to a603c5c Compare March 4, 2018 18:45

cpojer reviewed Mar 5, 2018

View reviewed changes

SimenB mentioned this pull request Mar 6, 2018

Feature Request: Allow to run a jest runner in band #5706

Closed

DanielMSchmidt force-pushed the add-serial-flag-for-runner branch 2 times, most recently from 2648e46 to 0e8934e Compare March 7, 2018 19:50

DanielMSchmidt force-pushed the add-serial-flag-for-runner branch 2 times, most recently from ba9cb3f to 2862c29 Compare March 7, 2018 20:06

SimenB reviewed Mar 8, 2018

View reviewed changes

Enable single thread mode for runner

f18a9e6

Some runners for tools that can not be run in parallel need a way to specify that they should not be executed in parallel. This commits adds this functionality. Closes jestjs#5706

DanielMSchmidt force-pushed the add-serial-flag-for-runner branch from 2862c29 to f18a9e6 Compare March 8, 2018 10:57

cpojer merged commit 5a07f5f into jestjs:master Mar 8, 2018

SimenB mentioned this pull request Sep 25, 2018

Feature Request: Add --runInBand to package.json options #3215

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable single thread mode for runner #5712

Enable single thread mode for runner #5712

DanielMSchmidt commented Mar 3, 2018 •

edited

Loading

SimenB left a comment

SimenB commented Mar 3, 2018

DanielMSchmidt commented Mar 4, 2018

codecov-io commented Mar 4, 2018 •

edited

Loading

cpojer Mar 5, 2018

DanielMSchmidt Mar 5, 2018

niieani Mar 5, 2018

SimenB commented Mar 5, 2018

DanielMSchmidt commented Mar 5, 2018

DanielMSchmidt commented Mar 7, 2018

SimenB Mar 8, 2018

DanielMSchmidt Mar 8, 2018

SimenB commented Mar 8, 2018

cpojer commented Mar 8, 2018

DanielMSchmidt commented Mar 8, 2018

cpojer commented Mar 8, 2018

DanielMSchmidt commented Mar 8, 2018

cpojer commented Mar 8, 2018

github-actions bot commented May 12, 2021

Enable single thread mode for runner #5712

Enable single thread mode for runner #5712

Conversation

DanielMSchmidt commented Mar 3, 2018 • edited Loading

Summary

Test plan

SimenB left a comment

Choose a reason for hiding this comment

SimenB commented Mar 3, 2018

DanielMSchmidt commented Mar 4, 2018

codecov-io commented Mar 4, 2018 • edited Loading

Codecov Report

cpojer Mar 5, 2018

Choose a reason for hiding this comment

DanielMSchmidt Mar 5, 2018

Choose a reason for hiding this comment

niieani Mar 5, 2018

Choose a reason for hiding this comment

SimenB commented Mar 5, 2018

DanielMSchmidt commented Mar 5, 2018

DanielMSchmidt commented Mar 7, 2018

SimenB Mar 8, 2018

Choose a reason for hiding this comment

DanielMSchmidt Mar 8, 2018

Choose a reason for hiding this comment

SimenB commented Mar 8, 2018

cpojer commented Mar 8, 2018

DanielMSchmidt commented Mar 8, 2018

cpojer commented Mar 8, 2018

DanielMSchmidt commented Mar 8, 2018

cpojer commented Mar 8, 2018

github-actions bot commented May 12, 2021

DanielMSchmidt commented Mar 3, 2018 •

edited

Loading

codecov-io commented Mar 4, 2018 •

edited

Loading