-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraalVM native support for Jetty WebSocket #11683
Comments
@olamy https://graalvm.github.io/native-build-tools/latest/maven-plugin.html I tried a quick addition of <groupId>org.graalvm.buildtools</groupId>
<artifactId>native-maven-plugin</artifactId>
<version>0.10.1</version> It seems to fork another build / test of everything. |
@joakime I will make some tests. But increasing so much the build time will be a pain (cache helps a lot when working on PR/branches). |
@joakime I'm not quite sure to understand how/why using this plugin in the case of Jetty build? |
Indeed, we usually recommend to use a dedicated profile to avoid slowing down the regular build. @joakime |
Need some special setup for Jenkins as something as simple as
Then
Turns into:
|
@sdeleuze I don't really understand why the native plugin doesn't skip |
I made a PR #11712 this need to have a local build of graalvm/native-build-tools#593 still some issues such
|
FYI; the latest PR made by the Spring team: oracle/graalvm-reachability-metadata#495 |
Hi, based on my tests with Spring, the main broken feature with Jetty + GraalVM native image is the WebSocket support that requires to work:
reflect-config.json
embedded resource or in https://github.com/oracle/graalvm-reachability-metadata, see below:We usually recommend OSS project to start by providing support on https://github.com/oracle/graalvm-reachability-metadata side as it provides the native testing infrastructure, but maybe you prefer to add it on Jetty side (but you should then probably add native tests). Could you provide insights on how you would prefer adding such native support in Jetty (happy to setup a call to discuss that if you want)?
The text was updated successfully, but these errors were encountered: