Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - portrait ratios for images #1623

Closed
pieterjandesmedt opened this issue Jan 24, 2018 · 4 comments
Closed

Feature request - portrait ratios for images #1623

pieterjandesmedt opened this issue Jan 24, 2018 · 4 comments

Comments

@pieterjandesmedt
Copy link
Contributor

This is about Bulma.

Thank you for this great framework!

Can we support portrait ratios corresponding the existing landscape ratios for images?
I'm thinking is-3by4, is-2by3, is-9by16, is-1by2.

Maybe add is-5by4 and is-4by5 too as it's also a common aspect ratio?

I'll create a PR if you want.

@yusufbicer
Copy link

Adding all these features will bloat Bulma, please use custom CSS file.

@pieterjandesmedt
Copy link
Contributor Author

Hmmm... Seems a bit arbitrary to only include landscape aspect ratios. Lots of sites (thinking e-commerce, portfolios, etc) use portrait ratios.

Also, adding this increases the css file size by a mere 611 bytes from 223.188 bytes to 223.799 bytes (less than 0.3%).

@3j14
Copy link

3j14 commented Feb 3, 2018

@yusufbicer I agree to @pieterjandesmedt. Landscape aspect ratios are already included. Why not portrait aspect ratios

@eppfel
Copy link

eppfel commented Mar 16, 2018

I also think this should be about, does bulma provide this feature or not. And if so, then of course portrait should be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants