Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The last button in list of full-width buttons has longer width #1991

Closed
SuperBo opened this issue Jul 13, 2018 · 6 comments · Fixed by tghelere/valorize-vidas#6 · May be fixed by devopsred/gaia#6, anikets43/angular-ngrx-socket-frontend#4 or jwlh/WDI_GROUP_PROJECT#2

Comments

@SuperBo
Copy link

SuperBo commented Jul 13, 2018

This is about Bulma | the Docs.

Overview of the problem

This is about the Bulma CSS framework
I'm using Bulma version [0.7.1]
My browser is: Opera

I am sure this issue is not a duplicate? Not sure!

Description

The last button in the list of full-width buttons is longer when comparing to the rest.
screen shot 2018-07-14 at 12 35 42 am

Steps to Reproduce

This error also occurs in the demo page of bulma.
https://bulma.io/documentation/elements/button/#displays

Expected behavior

The last button should have the same width as others in group.

Actual behavior

The last button has longer width than others in group.

@SuperBo SuperBo changed the title The last button in list of full-width buttons doesn't has longer width The last button in list of full-width buttons has longer width Jul 13, 2018
@willhoyle
Copy link

Seems to be the following code found here:

...

.buttons
  align-items: center
  display: flex
  flex-wrap: wrap
  justify-content: flex-start
  .button
    margin-bottom: 0.5rem
    &:not(:last-child)
      margin-right: 0.5rem

...

@jgthms
Copy link
Owner

jgthms commented Jul 21, 2018

Yeah I use the “buttons” class in the docs for most examples.

It’s not a bug per se because it’s just for educational purposes. Here’s the only case where it’s not great because all buttons are full width.

@danielhep
Copy link

I am encountering this. Did you guys just fix it with a custom CSS class? It's pretty annoying, but I understand why it exists. I think that fullwidth items should not have the margin on them.

@danielhep
Copy link

Update: This can be fixed with the following.

.buttons .button:not(:last-child).is-fullwidth {
  margin-right: 0
}

@jgthms
Copy link
Owner

jgthms commented Sep 4, 2018

&:not(:last-child):not(.is-fullwidth)
  margin-right: 0.5rem

should work.

@frederikhors
Copy link

@jgthms are you adding this in the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment