Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let "Input Folder Path" can handle videos #280

Open
mario-huang opened this issue Sep 17, 2024 · 2 comments
Open

let "Input Folder Path" can handle videos #280

mario-huang opened this issue Sep 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mario-huang
Copy link

When use "Click to Upload", we can upload videos.
But when use "Input Folder Path", it just ignores videos, can only handle audios.
And it will not recursively process when a folder has multiple levels of subdirectories.

Also, It would be best if there were an option to save the output directly in the same folder as the original file, instead of always saving it in a fixed 'outputs' folder.

@mario-huang mario-huang added the enhancement New feature or request label Sep 17, 2024
@jhj0517
Copy link
Owner

jhj0517 commented Sep 18, 2024

Hi. Thanks for raising the issue. Video files were already enabled, but I was missing some extension.

I added some in #282, it should work fine now. Can you check?

Regarding outputs path, you can use --output_dir.

python app.py --output_dir "\Path\Your\Outputs"

This will allow you to use a custom output path.

@mario-huang
Copy link
Author

Nice done! It worked.
When I say "And it will not recursively process when a folder has multiple levels of subdirectories." I mean this:
my-folder

  • sub-folder-1
    • 1.mp4
  • sub-folder-2
    • 2.mp4

If the folder path is /my-folder/, it can not find the x.mp4 in sub-folders.

When I say "It would be best if there were an option to save the output directly in the same folder as the original file, instead of always saving it in a fixed 'outputs' folder." I mean this:
my-folder

  • sub-folder-1
    • 1.mp4
    • 1.srt
  • sub-folder-2
    • 2.mp4
    • 2.srt

put the srt beside the mp4 would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants