V2 Proposal

[0x3333]

Version 2.0 Proposal

This issue will be a discussion point to exchange ideas about version 2.0.

Big picture

The community is urging for a more java idiom version, and the current version can't handle these changes, that's why I'm proposing a new version, incorporating all the needs from the community in a broad discussion.

What about v2?

The new version must be compatible with original implementation as much as it can, without sacrificing java idiom. We will discuss how it will be implemented and the design considerations will be made here.

@cazacugmihai Proposal

• Use of char arrays and StringBuilder instead of Strings
• Precompute and cache recurrent operations
• Helper class (CharUtils) for working with char arrays

@iggymoran Proposal

• [] Relax MAX_NUMBER restriction

@KangoV Proposal

• [] BigInteger as input/output

Reference implementation PR #53.

[cazacugmihai]

We can include these points in the TODO list.

Also, the 2.0.0 branch can be started from this point.

[kmandeville]

Has this library gone dark? Haven't been any updates for about 6 months?

[0x3333]

I'd would say it is stable... :)

As soon as I have some time, I'll work on 2.0.

[kmandeville]

:)

Yes, definitely stable! I was mainly wondering because of some issues I had been following to see if there were any updates or if there were going to be. It wasn't anything major. Just an edge case around ArrayIndexOutOfBoundsException being thrown. We can work around it though. Thanks!

[0x3333]

Mind opening an issue for this ArrayIndexOutOfBoundsException?

[kmandeville]

There was one already that I thought you had fixed, but I was waiting for a new release. It doesn't look like there was one. #45

…

On Wed, May 23, 2018 at 8:22 AM, Tercio Gaudencio Filho < ***@***.***> wrote: Mind opening an issue for this ArrayIndexOutOfBoundsException? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABql-N_-Wqv3a6R3pgv19f1fW5O7Qcmwks5t1VSYgaJpZM4SXN7i> .

[0x3333]

It was issued... 1.0.3. Maybe this is another bug...

[KangoV]

Any chance of being able to accept BigInteger as input/output?

[eriknyk]

what happened with v2? still not released...

[XhstormR]

ping

[fanweixiao]

@0x3333 seems busy. is there anyone interest in v2.0 implementation? @eriknyk @XhstormR

[eriknyk]

@fanweixiao yes

[0x3333]

Hi everyone. Sorry for the long delay, I'm quite busy here.

I believe a v2 is a must, I'll try to work it out next week. Any new requirements?

[chenzhenjia]

@0x3333 Can it be merged?

[0x3333]

I’m not working with hashids anymore. Take a look at https://github.com/sqids/sqids-java

[chenzhenjia]

I’m not working with hashids anymore. Take a look at https://github.com/sqids/sqids-java

hashids supports custom secret, which sqids cannot do

[rgmz]

I’m not working with hashids anymore. Take a look at https://github.com/sqids/sqids-java

hashids supports custom secret, which sqids cannot do

"Secret" or "salt" was a misnomer.

The salt parameter was used to shuffle the alphabet, and it was never meant to be associated with security or safety. Both Hashids and Sqids work similarly to the way decimal to hexadecimal conversion works but with a few adjustments. There is no encryption of any kind, so to avoid confusion, that parameter has been removed completely.

https://sqids.org/faq#salt