Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

I think we should rename createRouter #11

Open
stalkerg opened this issue Mar 1, 2018 · 3 comments
Open

I think we should rename createRouter #11

stalkerg opened this issue Mar 1, 2018 · 3 comments

Comments

@stalkerg
Copy link

stalkerg commented Mar 1, 2018

Right now "createRouter" when exist "create" function also createRouter contain proxy like methods to History.

@jikkai
Copy link
Owner

jikkai commented Mar 1, 2018

In my opinion, if we rename the createRouter function, it will make a little breaking changes.

So, maybe we can set an alia for createRouter, and keep createRouter for a while.

@antony
Copy link

antony commented Apr 8, 2018

I've started doing this:

import { createRouter as router } from 'svelte-router'

because calling createRouter.push() in my svelte components seems really odd.

@stalkerg
Copy link
Author

I am worried about an activity of this project, also it does not have full feature set what needed for routing system.
The solution from @TehShrike more acceptable but you should write more code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants