-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncoid initial replication fails when zfs dataset contains long entries for properties, ex. org.zfsbootmenu:commandline - No idea about successive sends with property set however... #945
Comments
Sorry; as far as I can tell you're going to need to open this upstream with OpenZFS and/or ZFSBootMenu. The error you're seeing is a direct I would encourage you to file this as an upstream bug, though, as it certainly doesn't seem like expected behavior. |
Sorry I didn't realize I wasn't clear. The property 'org.zfsbootmenu:commandline' is the embedded kernel command line switches for use with ZfsBootMenu. When I set it to blank, the transfer succeeded. Correct me if I am wrong, could just be an issue with how the error is reported, but it appears that the zfs receive option with preserving properties syncoid option, is not "quoting" the value for the org.zfsbootmenu:commandline ala
should look like this instead (basically quotes around the kernel option line coming after -o org.zfsbootmenu:commandline= )
I'm rusty on using the zfs receive option (Thanks to @jimsalterjrs / syncoid :) ) directly but when setting the option I had to use quotes initially ala I know most zfs set options are single words and don't need to be quoted. |
You're right, that was not clear! Can you please confirm, by first running the syncoid command that fails, using --debug if necessary to capture the final command line, then once it fails reissuing the zfs send | zfs receive command that --debug showed you, but with the quotes you believe are missing? That kind of direct confirmation accelerates bug fixes A LOT. :) In the meantime, I'm reopening this. Thanks for the clarification! |
Sure thing. |
Hmmm, I wonder if #946 addresses your issue as well? |
Sorry for the delay. The rpool/ROOT/pve-1 is set to the following. The I use this command:
Full debug output.
Unsetting via And rerunning the same command yields a perfect sync.
Well it is definitely because how the zfs recv command is constructed when preserving properties. Although its not a single quote vs double quote it seems. There is no quotes for the value of org.zfsbootmenu:commandline= |
Confirmed. Changing the debug output command:
to include the org.zfsbootmenu:commandline values quoted (double quotes) the command completes normally.
Additionally the org.zfsbootmenu:commandline is correct on the destination dataset.
|
Had to move some root pools around that I have setup using ZfsBootMenu.
ZBM of course asks for kernel options to be passed via dataset property.
With this combination of options and my long kernel command line syncoid bombs.
Had to blank the property before sending which is so far transfering correctly
The text was updated successfully, but these errors were encountered: