Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base frame header API on the net/textproto API #6

Open
jjeffery opened this issue Jan 15, 2014 · 0 comments
Open

Base frame header API on the net/textproto API #6

jjeffery opened this issue Jan 15, 2014 · 0 comments

Comments

@jjeffery
Copy link
Owner

Following on from issue #3, where it was suggested to put the header in a map rather than an array. Although a map implementation was considered originally, it was decided to use an array in order to (a) have some certainty about the order of header entries, and (b) handle repeated header entries in a deterministic manner.

I think a better implementation would be to have an API similar to the MIMEHeader type in the excellent net/textproto package (see http://golang.org/src/pkg/net/textproto/), but this would be a breaking change. I would probably create a StompHeader type based on MIMEHeader, but with the STOMP header rules (case-sensitive, no spaces, etc).

I am not sure how many people are actually using this library, and so I have no idea how much a breaking change would irritate people. Comments welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant